From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1645C1F5AE for ; Mon, 7 Jun 2021 01:19:20 +0000 (UTC) Received: from localhost ([::1]:34110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lq3vB-0003KV-S3 for normalperson@yhbt.net; Sun, 06 Jun 2021 21:19:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq3u9-0001OF-AB for bug-gnulib@gnu.org; Sun, 06 Jun 2021 21:18:13 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:53532) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lq3u3-0007CE-1M for bug-gnulib@gnu.org; Sun, 06 Jun 2021 21:18:13 -0400 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id D54DE72C8C5; Mon, 7 Jun 2021 04:10:27 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 9C30D7CC8BB; Mon, 7 Jun 2021 04:10:27 +0300 (MSK) Date: Mon, 7 Jun 2021 04:10:27 +0300 From: "Dmitry V. Levin" To: Egor Ignatov , Paul Eggert Subject: Re: [PATCH] regex: fix match with possessive quantifier Message-ID: <20210607011027.GA18724@altlinux.org> References: <20210526090819.7482-1-egori@altlinux.org> <20210606214502.GA16155@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210606214502.GA16155@altlinux.org> Received-SPF: pass client-ip=194.107.17.57; envelope-from=ldv@altlinux.org; helo=vmicros1.altlinux.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Mon, Jun 07, 2021 at 12:45:02AM +0300, Dmitry V. Levin wrote: > On Wed, May 26, 2021 at 12:08:19PM +0300, Egor Ignatov wrote: > > Fix behaviour introduced in 70b673e, where regexps with > > possessive quantifier("*+") didn't match. > > * lib/regexec.c > > (set_regs): Pop if CUR_NODE has already been checked only when > > we have a fail stack. > > > > Signed-off-by: Egor Ignatov > > --- > > Hi Paul, > > > > Do you have any test cases for bug 11053(glibc) for gnulib? > > This patch fixes the issue with "*+", but I'm not sure it > > doesn't break your fix for 11053. > > Thanks, the fix looks plausible, it doesn't break any tests > (including those introduced along with commit 70b673eb7), Apparently, there are more issues with commit 70b673eb7, for example: $ echo ab | sed -E 's/^(a*)*(.)\1/\1/' Segmentation fault $ echo ab | strace -enone -- sed --debug -E 's/^(a*)*(.)\1/\1/' SED PROGRAM: s/^(a*)*(.)\\1/\1/ INPUT: 'STDIN' line 1 PATTERN: ab COMMAND: s/^(a*)*(.)\\1/\1/ MATCHED REGEX REGISTERS regex[0] = 0-2 'ab' regex[1] = 0--1 'ab!!ab ' --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x20} --- +++ killed by SIGSEGV +++ Segmentation fault -- ldv