malloc/dynarray-skeleton.c problems on MacOS 10.13.6 and 10.15.7

malloc/dynarray-skeleton.c problems on MacOS 10.13.6 and 10.15.7

[arnold]

Hi Paul & Jim,

Please see the report below from Nelson Beebe, attempting to build
https://www.skeeve.com/gawk/gawk-5.1.1a.tar.gz on recent MacOS.
This a test release, working towards a real release.

Can you pleae work directly with Nelson in terms of patches etc and
then let me know when Gnulib is updated?

Much thanks,

Arnold

> Date: Thu, 6 May 2021 15:15:08 -0600
> From: "Nelson H. F. Beebe" <beebe@math.utah.edu>
> Subject: Re: Release spiral start
>
> I got successful builds and installations of gawk-5.1.1a on several
> systems, include CentOS 5/6/7/8, Ubuntu 20.04, Debian 7 (MIPS32),
> Oracle 8, Red Hat 8, and Solaris 10, but build attempts on macOS
> 10.13.6 and 10.15.7 with both Apple's /usr/bin/cc (really clang 12)
> and /usr/bin/gcc (clang 12 masquerading as gcc), plus on macOS
> 10.13.6, gcc-{4,5,6,7,8,9,10,11,12}, have all failed.
>
> The killer code is the several instances of __nonnull ((1)) in
> support/malloc/dynarray-skeleton.c.  They produce a cascade of errors
> that start like this:
>
> 	/usr/bin/gcc -DGAWK -DHAVE_CONFIG_H -I"./.." -I. -I..    \
>                      -g -O2 -DNDEBUG -g -O2 -DNDEBUG -MT regex.o \
>                      -MD -MP -MF $depbase.Tpo -c -o regex.o      \
>                      regex.c &&                                  \
> 	mv -f $depbase.Tpo $depbase.Po
> In file included from regex.c:74:
> In file included from ./regexec.c:1368:
> ./malloc/dynarray-skeleton.c:195:13: error: expected ')'
> __nonnull ((1))
>             ^
> ./malloc/dynarray-skeleton.c:195:12: note: to match this '('
> __nonnull ((1))
>            ^
> ./malloc/dynarray-skeleton.c:195:13: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
> __nonnull ((1))
>             ^
> ./malloc/dynarray-skeleton.c:195:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
> __nonnull ((1))
>
> ... many more ...
>
> -------------------------------------------------------------------------------
> - Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
> - University of Utah                    FAX: +1 801 581 4148                  -
> - Department of Mathematics, 110 LCB    Internet e-mail: beebe@math.utah.edu  -
> - 155 S 1400 E RM 233                       beebe@acm.org  beebe@computer.org -
> - Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
> -------------------------------------------------------------------------------

Re: malloc/dynarray-skeleton.c problems on MacOS 10.13.6 and 10.15.7

[Jeffrey Walton]

On Fri, May 7, 2021 at 2:13 AM <arnold@skeeve.com> wrote:
>
> Hi Paul & Jim,
>
> Please see the report below from Nelson Beebe, attempting to build
> https://www.skeeve.com/gawk/gawk-5.1.1a.tar.gz on recent MacOS.
> This a test release, working towards a real release.
>
> Can you pleae work directly with Nelson in terms of patches etc and
> then let me know when Gnulib is updated?

I can't speak for others, but I solve it with:

    grep -IR nonnull ./* | cut -f 1 -d ':' | sort | uniq

Then, for each file in the list:

    sed -e 's/__nonnull ((1))//g' \
        -e 's/__nonnull ((1, 2))//g' \
        "${file}" > "${file}.fixed"
    mv "${file}.fixed" "${file}"

(You will need it for more than Awk. Wget and a couple of others need
the treatment, too).

Jeff

Re: malloc/dynarray-skeleton.c problems on MacOS 10.13.6 and 10.15.7

[arnold]

Jeffrey Walton <noloader@gmail.com> wrote:

> On Fri, May 7, 2021 at 2:13 AM <arnold@skeeve.com> wrote:
> >
> > Hi Paul & Jim,
> >
> > Please see the report below from Nelson Beebe, attempting to build
> > https://www.skeeve.com/gawk/gawk-5.1.1a.tar.gz on recent MacOS.
> > This a test release, working towards a real release.
> >
> > Can you pleae work directly with Nelson in terms of patches etc and
> > then let me know when Gnulib is updated?
>
> I can't speak for others, but I solve it with:
>
>     grep -IR nonnull ./* | cut -f 1 -d ':' | sort | uniq
>
> Then, for each file in the list:
>
>     sed -e 's/__nonnull ((1))//g' \
>         -e 's/__nonnull ((1, 2))//g' \
>         "${file}" > "${file}.fixed"
>     mv "${file}.fixed" "${file}"
>
> (You will need it for more than Awk. Wget and a couple of others need
> the treatment, too).
>
> Jeff

Thanks. I can do this, but I'd prefer to see it fixed upstream...

Arnold

Re: malloc/dynarray-skeleton.c problems on MacOS 10.13.6 and 10.15.7

[Paul Eggert]

On 5/6/21 11:23 PM, arnold@skeeve.com wrote:
> I'd prefer to see it fixed upstream...

It was fixed upstream a couple of weeks ago. You should be able to fix 
the Gawk issue by syncing Gawk from Gnulib.

Re: malloc/dynarray-skeleton.c problems on MacOS 10.13.6 and 10.15.7

[arnold]

Paul Eggert <eggert@cs.ucla.edu> wrote:

> On 5/6/21 11:23 PM, arnold@skeeve.com wrote:
> > I'd prefer to see it fixed upstream...
>
> It was fixed upstream a couple of weeks ago. You should be able to fix 
> the Gawk issue by syncing Gawk from Gnulib.

Thanks, will do.

Arnold