From: "Dmitry V. Levin" <ldv@altlinux.org>
To: arnold@skeeve.com
Cc: bug-gnulib@gnu.org, bruno@clisp.org
Subject: Re: current gnulib regex breaks in gawk
Date: Sat, 17 Apr 2021 01:30:45 +0300 [thread overview]
Message-ID: <20210416223045.GC17630@altlinux.org> (raw)
In-Reply-To: <202102080636.1186aTQY012783@freefriends.org>
Hi Arnold,
On Sun, Feb 07, 2021 at 11:36:29PM -0700, arnold@skeeve.com wrote:
> arnold@skeeve.com wrote:
>
> > I still have to have the following change, otherwise I get a linkage
> > error on the gl_dyanarray_* routines. :-(
> >
> > So, at least for the nonce, my copy and Gnulib's will be out of sync.
> > Oh well.
>
> So actually, I've managed to work around this issue too. So the files
> are back in sync. Whew!
I've just tried to build the latest commit gawk-5.1.0-260-gde598391 from
gawk-5.1-stable branch. Unfortunately, the result executable uses a
private glibc interface:
$ nm gawk |grep GLIBC_PRIVATE
U __libc_dynarray_resize@GLIBC_PRIVATE
This makes it unusable at least in GNU/Linux distributions.
Such an unfortunate result is due to very unusual method used to integrate
dynarray module from gnulib into gawk:
- unlike gnulib's lib/dynarray.h, gawk's support/dynarray.h is empty;
- gnulib's lib/malloc/dynarray_resize.c is not imported into gawk's
support/malloc/ at all.
I was able to make an ad-hoc fix by replacing gawk's support/dynarray.h
with gnulib's lib/dynarray.h, importing gnulib's
lib/malloc/dynarray_resize.c as support/malloc/dynarray_resize.c,
and adding malloc/dynarray_resize.c to libsupport_a_SOURCES of
support/Makefile.am, hope this helps.
I wish gawk sources used some gnulib module import automation, e.g.
gnulib-tool script, like many other gnulib users do, that would make
updating gnulib modules a relatively straightforward task.
--
ldv
next prev parent reply other threads:[~2021-04-16 22:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 9:57 current gnulib regex breaks in gawk arnold
2021-02-07 10:29 ` Bruno Haible
2021-02-07 12:08 ` arnold
2021-02-07 13:07 ` Bruno Haible
2021-02-08 6:11 ` arnold
2021-02-08 6:36 ` arnold
2021-04-16 22:30 ` Dmitry V. Levin [this message]
2021-04-17 19:18 ` arnold
2021-04-17 19:43 ` arnold
2021-04-17 21:40 ` Dmitry V. Levin
2021-04-18 5:53 ` arnold
2021-04-22 6:52 ` arnold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416223045.GC17630@altlinux.org \
--to=ldv@altlinux.org \
--cc=arnold@skeeve.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).