From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8E4C31F4B4 for ; Sat, 23 Jan 2021 11:23:25 +0000 (UTC) Received: from localhost ([::1]:36580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3H0m-0000qI-Mu for normalperson@yhbt.net; Sat, 23 Jan 2021 06:23:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Gzw-0000Ns-Ln for bug-gnulib@gnu.org; Sat, 23 Jan 2021 06:22:32 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:37399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3Gzt-0004XM-4Z for bug-gnulib@gnu.org; Sat, 23 Jan 2021 06:22:31 -0500 Received: by mail-wr1-x42a.google.com with SMTP id v15so7522092wrx.4 for ; Sat, 23 Jan 2021 03:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PzKPB9R1WBZ1xiJWkfnj0GeSItqJ3AG+Z492q6VGFZ8=; b=ZxjbxkCk3v8Ud5XQd1L/R9Gqq8P2Mvc4Sgf9EoDT9E7DwHWanQGW700Q3yMKn4R/ro TfvUZa/yhEeP4L4qWDMJvRDt1ClUtsyu0UhHVg+CkcWQamRhQt2VZbbRkWNrGgNBhaCe hfTGb1RJUYqBr51IpnVBPV+lwmw/IFk+i7iboWvZpyOKI2t5GSBO1rhkPHtQQRSc3yW9 CdppmZ1yjCQBpH01CheJNq0jyeXh/esyUSshLSyvVyn7cfhjTXlZUhSoA+u1Db9+o4ND 8PfvgxjgHOeRfI+NYFXavO/P5Zvrbsbwik7QWKizFvFwt6DEWYr+ZL+aiPv1nbU+Tjxe Z01w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PzKPB9R1WBZ1xiJWkfnj0GeSItqJ3AG+Z492q6VGFZ8=; b=Bg/4IWxQJ3yF7/qOHsLtLoh3EXDzaDiLku7voGVshVijCE+vsu2KKzE8CfSR3tsWoH bYlC3GADx62PqzuQYCw2YVCyblu9CEIVsF1Ni69xubYqOsolVRej7zjGRGEu0XRR+jmv NBY+wjDWHh9nlzqUVPt3lVrA8DqvIWnygmvrPAqqMyNfs8eadk4UrHOlYH+fHdFHCzKl 7PL1lBN6ZY1iqtlER7hKSSMT5RH+IJoaEnutNKIj+nSSncCJ05SYHIHv0LZY1/AKQuIA TryBPtR3D/XN13koaUVTsKsJ1DhFJqv5xdvAn/OXzcFVvDzI9fItnwcHQY5/tZfR44jm FNhQ== X-Gm-Message-State: AOAM531MiGFJzF5Oxi/qxzCHPd/KfT29byy28eBPSwwsMKM3bpkekSLu MN8YGSqAmIFtXFjDzOxnRSz4IaXnNek= X-Google-Smtp-Source: ABdhPJzndQRpL2Ql/b+NCDJw1F5fgnl64gyNikEIS5pMYrV7ytrpS26a1hlyI4GNxnRAQk8RgoLj0w== X-Received: by 2002:a5d:4d4f:: with SMTP id a15mr8675159wru.315.1611400946044; Sat, 23 Jan 2021 03:22:26 -0800 (PST) Received: from localhost ([2a01:e0a:3d3:9cc1:c5e2:6877:2efd:7c77]) by smtp.gmail.com with ESMTPSA id q7sm14711249wmq.0.2021.01.23.03.22.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jan 2021 03:22:24 -0800 (PST) From: roucaries.bastien@gmail.com X-Google-Original-From: rouca@debian.org To: bug-gnulib@gnu.org Subject: [PATCH 2/2] Implement fallback for explicit_bzero using jump to volatile pointer Date: Sat, 23 Jan 2021 11:22:11 +0000 Message-Id: <20210123112211.198683-3-rouca@debian.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210123112211.198683-1-rouca@debian.org> References: <20210123112211.198683-1-rouca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=roucaries.bastien@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Bastien=20Roucari=C3=A8s?= Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" From: Bastien Roucariès Signed-off-by: Bastien Roucariès --- lib/explicit_bzero.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/explicit_bzero.c b/lib/explicit_bzero.c index 71a1cca3b0..c39f20164b 100644 --- a/lib/explicit_bzero.c +++ b/lib/explicit_bzero.c @@ -54,11 +54,10 @@ explicit_bzero (void *s, size_t len) explicit_memset (s, '\0', len); #elif HAVE_MEMSET_S (void) memset_s (s, len, '\0', len); -#else +#elif defined __GNUC__ memset (s, '\0', len); -# if defined __GNUC__ /* Compiler barrier. */ -# if !defined __clang__ +# if !defined __clang__ asm volatile ("" ::: "memory"); # else /* See https://bugs.llvm.org/show_bug.cgi?id=15495#c11 @@ -70,5 +69,8 @@ explicit_bzero (void *s, size_t len) __asm__ volatile("" : : "g"(s) : "memory"); # endif # endif +#else + void * (* const volatile volatile_memset)(void *, int, size_t) = memset; + (void) volatile_memset (s, '\0', len); #endif } -- 2.29.2