From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 199781F4B4 for ; Sat, 23 Jan 2021 11:05:06 +0000 (UTC) Received: from localhost ([::1]:59650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Gj3-0006EE-8R for normalperson@yhbt.net; Sat, 23 Jan 2021 06:05:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3GUV-0005n7-9Q for bug-gnulib@gnu.org; Sat, 23 Jan 2021 05:50:03 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:38416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3GUT-0006ZJ-Er for bug-gnulib@gnu.org; Sat, 23 Jan 2021 05:50:02 -0500 Received: by mail-wr1-x42d.google.com with SMTP id a9so7473089wrt.5 for ; Sat, 23 Jan 2021 02:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yB6M81jxSfvtgwi/SXYbZMsae5FbujlB8w1HxnWdlhU=; b=J8eA/eybyVObMf6R3K0jiNu2trUviYKwspXCJsCfBXjp7CE70ldpqkiAH7uPi3lgFg KWmgyts0UcCbSgLBxdcEj+MIcuCC2QVWGr56OEP/XY61i7kSho0mUqCgD80CSFHkZcc5 mXq1eGcfwMycmQQbmJoQISyU1nANDWP0NBLMaHf6XpcQg1kojmAqTIi13M4c/x3ze2Qq +DT+3ySqYph7LyrUPvCGSkNNYvZb7OzC0JVkoYB1H9gf6zBQRm3M5nLB1elFJUYqDv3o abSXYDXUob05SxV8+/eZ8CWPmKOKWyARMUZwjHQwWMn3P+g2Nq5Wkm8pEn8o7UHTJ8XH aR8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yB6M81jxSfvtgwi/SXYbZMsae5FbujlB8w1HxnWdlhU=; b=h5AzusrdvSAc+X/CImLZUWnj8hIskX26zc16YG77t1i6Iy/+aPSJr08UaTCRS6hWBR HkTnX+m+XVfhAfBLWW2alg4gO4kK6gtBkk0ybEVln7AoMT4RUbYmXvPy76dKf0CIuAwQ CYwm2cxfvviJTAD6ukxNLvxQm/plte+R68EmcbHJnNcrW6pam2eQNf4tZLfaxubRR2Vj cRnOaM61KQ4ayvIQlYjuTrKX9D8FU1lTZdrzYE7vfC0AyTp/MAFsH1DD3yMa/dW0+5Z5 HanHNmCgHs764kxL22pTLjJkjB3AHdMovNSLufvpgk7kvsqT8X1k5P3sY7fObH0KZF1q ygeg== X-Gm-Message-State: AOAM530nn7UEues21kR5lHiHTS79KoKCTUVQOJiKyZVem6gxJlb5GIcT 8h8La2952dcEBtjUCGPGXE5GfR9sO9I= X-Google-Smtp-Source: ABdhPJxKCz9oEtOD4vir1eEUzaB+ZuFqa/A54B9Sh4PsV8gFeFyTi3dpU4vUPT6PO7u0c9oMCh0xZQ== X-Received: by 2002:adf:fbc5:: with SMTP id d5mr8592929wrs.82.1611398999439; Sat, 23 Jan 2021 02:49:59 -0800 (PST) Received: from localhost ([2a01:e0a:3d3:9cc1:c5e2:6877:2efd:7c77]) by smtp.gmail.com with ESMTPSA id s19sm17362283wrf.72.2021.01.23.02.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jan 2021 02:49:58 -0800 (PST) From: roucaries.bastien@gmail.com X-Google-Original-From: rouca@debian.org To: bug-gnulib@gnu.org Subject: [PATCH 1/2] Support clang for explicit_bzero Date: Sat, 23 Jan 2021 10:49:44 +0000 Message-Id: <20210123104945.194017-2-rouca@debian.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210123104945.194017-1-rouca@debian.org> References: <20210123104945.194017-1-rouca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=roucaries.bastien@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Bastien=20Roucari=C3=A8s?= Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" From: Bastien Roucariès According to https://bugs.llvm.org/show_bug.cgi?id=15495#c11 llvm need g type constraint Signed-off-by: Bastien Roucariès --- lib/explicit_bzero.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/explicit_bzero.c b/lib/explicit_bzero.c index 87fadba81a..71a1cca3b0 100644 --- a/lib/explicit_bzero.c +++ b/lib/explicit_bzero.c @@ -56,9 +56,19 @@ explicit_bzero (void *s, size_t len) (void) memset_s (s, len, '\0', len); #else memset (s, '\0', len); -# if defined __GNUC__ && !defined __clang__ - /* Compiler barrier. */ +# if defined __GNUC__ +/* Compiler barrier. */ +# if !defined __clang__ asm volatile ("" ::: "memory"); +# else + /* See https://bugs.llvm.org/show_bug.cgi?id=15495#c11 + with asm("" ::: "memory") LLVM analyzes uses of 's' + and finds that the whole thing is dead and eliminates it. + + Using g workarround this problem + */ + __asm__ volatile("" : : "g"(s) : "memory"); +# endif # endif #endif } -- 2.29.2