From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2BD631F4B4 for ; Mon, 28 Dec 2020 14:01:37 +0000 (UTC) Received: from localhost ([::1]:49978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktt5c-0002Tl-AV for normalperson@yhbt.net; Mon, 28 Dec 2020 09:01:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktt44-0001mO-R4 for bug-gnulib@gnu.org; Mon, 28 Dec 2020 09:00:02 -0500 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:45753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktt43-0003E2-BF for bug-gnulib@gnu.org; Mon, 28 Dec 2020 09:00:00 -0500 Received: by mail-qk1-x734.google.com with SMTP id b64so8769696qkc.12 for ; Mon, 28 Dec 2020 05:59:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LmQg2lOefaynJUHiCfMOninl/m1Oi/ewIzM+z4j8Rso=; b=dkkanRL7jstiZ5JvSWqPrZquT8zo9CYbkK/79VOqotyhuah2eA5nj5aYjux9mQBQA+ gjJWx5HYsJiDOVsjBP0fvPZn6pvJGVSU197mJeXlUS/fe2DJimvSx/B2i/dhqxZOyY2z E33IPPml/tKyLcbSkwcgIx2xOEP+oI6evbPh/W7GY6j2uhDvcuhR1GEFgZeozHxFL8en rd16QZy+Cu7Ek1Ril5nDSzbLA2PP85cQRJ+ztUTmbbpF7t1XnFkFQEfabG7ux7a33Zjv GmxQad2xiE5KjNZ+TJ01NcSc+mbhqfvLMCSN95krxPu4wtL2sO+xKX5mzA6G/aiTEb5P lfAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LmQg2lOefaynJUHiCfMOninl/m1Oi/ewIzM+z4j8Rso=; b=U2mEJnP6yhnd81pyEe3Gqfzrf6Ch8tLk41+qIPSatNY4X5Pfc793yY5oqggnEd1Mfr AX2pLJE0y5KhcGSJasSB5e9yu6hbgN4mD4ZKGPnTXvoxSIWndR/p36ECtkN50dwpq5vy mo8AETeoetW2Rdc/UG1T5IDl6VbxpGURbIqljNNCd36YY3zCsv3+ZrNCAqkkMfFD/MrF YKm4GoZIKaFcjuNv2EAYA/pVkgRDCg3OFrfmgOJOLNVZDn0sg0ezWTS0NokVgvE2qJ6l NhGUyNcrP7b8mH0S4k1S8MRXexioRHHtn4vXKdGP9p3AnLYPefw7nmm0MiLumfpMQ+f0 pI8g== X-Gm-Message-State: AOAM533OU/P5cvvrs2nfyLtvHvXsQx3NZ11Eoiszu6rU1M5l0FD4akYM KWtplF2q6Szc81Q5ysAq0LFIAkDfBbPnQg== X-Google-Smtp-Source: ABdhPJzLzxfLKRFtEs6HqqrqhDQD0uIvpxNlLdfDV40dOMPwxOM+3Y/nu0p0OUG2max13P4YhZD6LA== X-Received: by 2002:a37:9d0e:: with SMTP id g14mr43952432qke.125.1609163998461; Mon, 28 Dec 2020 05:59:58 -0800 (PST) Received: from localhost.localdomain ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id i17sm24243744qtg.77.2020.12.28.05.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 05:59:58 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Paul Eggert Subject: [PATCH v2 6/6] stdlib: Assume FACCESSAT_NEVER_EOVERFLOWS on realpath Date: Mon, 28 Dec 2020 10:59:44 -0300 Message-Id: <20201228135944.1018303-6-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201228135944.1018303-1-adhemerval.zanella@linaro.org> References: <20201228135944.1018303-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=adhemerval.zanella@linaro.org; helo=mail-qk1-x734.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" The faccessat (..., AT_EACCESS) on Linux fallback will either use __NR_faccessat for __libc_enable_secure or LFS fstatat call. Neither fallbacks returns EOVERFLOW in failure case. Checked on x86_64-linux-gnu. --- stdlib/canonicalize.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/stdlib/canonicalize.c b/stdlib/canonicalize.c index 69f978da78..5aac8d457c 100644 --- a/stdlib/canonicalize.c +++ b/stdlib/canonicalize.c @@ -44,15 +44,10 @@ #ifdef _LIBC # include -# include -# ifdef __ASSUME_FACCESSAT2 -# define FACCESSAT_NEVER_EOVERFLOWS __ASSUME_FACCESSAT2 -# else -# define FACCESSAT_NEVER_EOVERFLOWS true -# endif # define GCC_LINT 1 # define _GL_ATTRIBUTE_PURE __attribute__ ((__pure__)) # define FUNC_REALPATH_WORKS 1 +# define FACCESSAT_NEVER_EOVERFLOWS true #else # define __canonicalize_file_name canonicalize_file_name # define __realpath realpath @@ -82,7 +77,7 @@ # define __pathconf pathconf # define __rawmemchr rawmemchr # define __readlink readlink -# define __stat stat +# define FACCESSAT_NEVER_EOVERFLOWS false #endif /* Suppress bogus GCC -Wmaybe-uninitialized warnings. */ @@ -95,9 +90,6 @@ #ifndef DOUBLE_SLASH_IS_DISTINCT_ROOT # define DOUBLE_SLASH_IS_DISTINCT_ROOT false #endif -#ifndef FACCESSAT_NEVER_EOVERFLOWS -# define FACCESSAT_NEVER_EOVERFLOWS false -#endif #if !FUNC_REALPATH_WORKS || defined _LIBC -- 2.25.1