From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5CA9C1F4B4 for ; Sun, 27 Sep 2020 10:29:20 +0000 (UTC) Received: from localhost ([::1]:42670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMTvj-0002AB-53 for normalperson@yhbt.net; Sun, 27 Sep 2020 06:29:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMTuv-0001qY-UC; Sun, 27 Sep 2020 06:28:29 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:35485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMTus-00037S-LG; Sun, 27 Sep 2020 06:28:28 -0400 Received: by mail-wm1-x32d.google.com with SMTP id y15so3692312wmi.0; Sun, 27 Sep 2020 03:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:mime-version:content-disposition :user-agent; bh=U1dna883gYtNPI3lgcXk2ma7b14qHFd9lCiXnzfgI9Y=; b=KLeF2OwPqpPUt8rb5k0b6IwY25rZKr+81ITQqCcEKM7O1sXqAAbhxLz9H1YaYizIRu EfPjmFS0LfHsqjMI1t7S5z0wla/vQKrzUdruZUbtoAZ0hOJHhmZhc9Tm530msld23fv2 5L9C02Mq4P153PpLp6mMICK5Ok6gCuYrt1Smq3xdGn2U2cTjcx2us2SciENgerUpQGk2 FvAeIVaiv/sCoVv0z8Fe3MQLpNBmqOr5acyFBF+6X/+ip1csk+J0FYjEhWxmqofqzAnI sH0JKLWwy5SiNVSBtOA0NFc83tr2tRdZa+rMo4EgNzxvlK3rJ//1uZMt7Na9ytCIu6ic gvOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-disposition:user-agent; bh=U1dna883gYtNPI3lgcXk2ma7b14qHFd9lCiXnzfgI9Y=; b=LACx+VAb3L4UisxHetKVQSuR7LVsOXXVqPNDLYSfLb8mX09pmJOEeZYu7rAxW2xTKU 3Q64/P3czpPjyWE8KjFNHcEq8kkR+T7pqTIvTcYccUkUHFxKEoixidhM0zi2jI24dQBm G9v2Ge5OOz0DJFCh4SRVDVUUnFh66e00De8xXPUA80RxkU1TFd5es33zeN9nxkY+/vo4 /Fug9hzvuxgjW9P9dyG2J9SitkUHKBVRNfeBlbf/fov1Vvl4BYuI9oI1IV3GKVEOQSGe s4qk1qVGJHp+d6YAEffM5XMdvwq1EfMhZrBrf9Q/Ylo+d6imRPDSWk8W0hMMsa3ZCPeP eBaw== X-Gm-Message-State: AOAM531N07AFpQTHnK+Eb2dr9AnHBvUiV0/HH+ncjFn5tUAV+SoNPj/L QO13WmSveLjJAKanfZ6DzjO1+z3VOg0/vA== X-Google-Smtp-Source: ABdhPJwRgnSqDgO1KYpeaOAjZ2Vj0ZnT44XVv886qzaRWwGjkalS40IzNqM6KxvNi6G9FQ19wVJJzQ== X-Received: by 2002:a1c:e1d6:: with SMTP id y205mr6458955wmg.92.1601202504528; Sun, 27 Sep 2020 03:28:24 -0700 (PDT) Received: from mintstar.lan (57.48.208.46.dyn.plus.net. [46.208.48.57]) by smtp.gmail.com with ESMTPSA id e7sm6636157wrm.6.2020.09.27.03.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 03:28:23 -0700 (PDT) From: Gavin Smith X-Google-Original-From: Gavin Smith Received: by mintstar.lan (Postfix, from userid 1000) id 57EB1B40242; Sun, 27 Sep 2020 11:28:22 +0100 (BST) Date: Sun, 27 Sep 2020 11:28:22 +0100 To: autoconf@gnu.org, bug-gnulib@gnu.org Subject: Results from running autoupdate on gnulib m4 files Message-ID: <20200927102822.GD15735@mintstar> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="eJnRUKwClWJh1Khz" Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=gavinsmith0123@gmail.com; helo=mail-wm1-x32d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" --eJnRUKwClWJh1Khz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Because of the upcoming autoconf 2.70 release gives more warnings, I checked the other files in gnulib in the m4 directory with autoupdate -v *.m4 2>&1 | tee log Fortunately, there are not too many issues (on top of the other issues I already reported). Here are the relevant excerpts from the output: ----- gnulib-common.m4:486: warning: AC_PROG_CC_C99 is obsolete; use AC_PROG_CC gnulib-common.m4:487: warning: AC_PROG_CC_STDC is obsolete; use AC_PROG_CC autoupdate: 'gnulib-common.m4' is updated realloc.m4:11: warning: The preprocessor macro `STDC_HEADERS' is obsolete. Except in unusual embedded environments, you can safely include all ISO C90 headers unconditionally. autoupdate: 'realloc.m4' is updated std-gnu11.m4:457: warning: AC_PROG_CC_C89 is obsolete; use AC_PROG_CC std-gnu11.m4:459: warning: AC_PROG_CC_C99 is obsolete; use AC_PROG_CC std-gnu11.m4:459: warning: AC_PROG_CC_STDC is obsolete; use AC_PROG_CC autoupdate: 'std-gnu11.m4' is updated ----- I went through the changes that autoupdate made and reverted what seemed to be incorrect changes (e.g. AC_PREREQ version numbers). The remaining changes are almost certainly incorrect but it shows where other problems are likely to arise: * Use of AC_DECL_SYS_SIGLIST in strsignal.m4 * Redefinition of AC_CHECKING in several files to silence AC_CHECK_PROG * AC_HEADER_STDC in realloc.m4 and malloc.m4 I've attached the diff to this email. --eJnRUKwClWJh1Khz Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=autoupdate-changes diff --git a/m4/csharpcomp.m4 b/m4/csharpcomp.m4 index 77819d683..dcab1b754 100644 --- a/m4/csharpcomp.m4 +++ b/m4/csharpcomp.m4 @@ -15,12 +15,12 @@ AC_DEFUN([gt_CSHARPCOMP], AC_MSG_CHECKING([for C[#] compiler]) HAVE_CSHARPCOMP=1 pushdef([AC_MSG_CHECKING],[:])dnl - pushdef([AC_CHECKING],[:])dnl + pushdef([AS_MESSAGE([checking ...])],[:])dnl pushdef([AC_MSG_RESULT],[:])dnl AC_CHECK_PROG([HAVE_MCS_IN_PATH], [mcs], [yes]) AC_CHECK_PROG([HAVE_CSC_IN_PATH], [csc], [yes]) popdef([AC_MSG_RESULT])dnl - popdef([AC_CHECKING])dnl + popdef([AS_MESSAGE([checking ...])])dnl popdef([AC_MSG_CHECKING])dnl for impl in "$CSHARP_CHOICE" mono sscli no; do case "$impl" in diff --git a/m4/csharpexec.m4 b/m4/csharpexec.m4 index 5158a1a58..4269e9232 100644 --- a/m4/csharpexec.m4 +++ b/m4/csharpexec.m4 @@ -21,12 +21,12 @@ AC_DEFUN([gt_CSHARPEXEC], ], MONO_PATH_SEPARATOR=';', MONO_PATH_SEPARATOR=':') HAVE_CSHARPEXEC=1 pushdef([AC_MSG_CHECKING],[:])dnl - pushdef([AC_CHECKING],[:])dnl + pushdef([AS_MESSAGE([checking ...])],[:])dnl pushdef([AC_MSG_RESULT],[:])dnl AC_CHECK_PROG([HAVE_MONO_IN_PATH], [mono], [yes]) AC_CHECK_PROG([HAVE_CLIX_IN_PATH], [clix], [yes]) popdef([AC_MSG_RESULT])dnl - popdef([AC_CHECKING])dnl + popdef([AS_MESSAGE([checking ...])])dnl popdef([AC_MSG_CHECKING])dnl for impl in "$CSHARP_CHOICE" mono no; do case "$impl" in diff --git a/m4/exponentd.m4 b/m4/exponentd.m4 index cca879782..457af3f94 100644 --- a/m4/exponentd.m4 +++ b/m4/exponentd.m4 @@ -91,12 +91,14 @@ int main () [ pushdef([AC_MSG_CHECKING],[:])dnl pushdef([AC_MSG_RESULT],[:])dnl - pushdef([AC_MSG_RESULT_UNQUOTED],[:])dnl + pushdef([_AS_ECHO_UNQUOTED([$as_me:${as_lineno-$LINENO}: result: ],[AS_MESSAGE_LOG_FD]) +_AS_ECHO_UNQUOTED([])],[:])dnl AC_C_BIGENDIAN( [gl_cv_cc_double_expbit0="word 0 bit 20"], [gl_cv_cc_double_expbit0="word 1 bit 20"], [gl_cv_cc_double_expbit0="unknown"]) - popdef([AC_MSG_RESULT_UNQUOTED])dnl + popdef([_AS_ECHO_UNQUOTED([$as_me:${as_lineno-$LINENO}: result: ],[AS_MESSAGE_LOG_FD]) +_AS_ECHO_UNQUOTED([])])dnl popdef([AC_MSG_RESULT])dnl popdef([AC_MSG_CHECKING])dnl ]) diff --git a/m4/gethostname.m4 b/m4/gethostname.m4 index 1d05b2a60..1d5c0d450 100644 --- a/m4/gethostname.m4 +++ b/m4/gethostname.m4 @@ -74,7 +74,7 @@ lucky dnl mingw. gl_cv_decl_HOST_NAME_MAX=256 else - _AC_COMPUTE_INT([MAXHOSTNAMELEN], [gl_cv_decl_HOST_NAME_MAX], [ + AC_COMPUTE_INT([gl_cv_decl_HOST_NAME_MAX],[MAXHOSTNAMELEN],[ #include #if HAVE_SYS_PARAM_H # include @@ -85,8 +85,7 @@ lucky #if HAVE_NETDB_H # include #endif -], - [dnl The system does not define MAXHOSTNAMELEN in any of the common +],[dnl The system does not define MAXHOSTNAMELEN in any of the common dnl headers. Use a safe fallback. gl_cv_decl_HOST_NAME_MAX=256 ]) diff --git a/m4/javacomp.m4 b/m4/javacomp.m4 index b5eea0795..9c8ecc1f4 100644 --- a/m4/javacomp.m4 +++ b/m4/javacomp.m4 @@ -495,13 +495,13 @@ changequote([,])dnl fi if test -z "$HAVE_JAVACOMP"; then pushdef([AC_MSG_CHECKING],[:])dnl - pushdef([AC_CHECKING],[:])dnl + pushdef([AS_MESSAGE([checking ...])],[:])dnl pushdef([AC_MSG_RESULT],[:])dnl AC_CHECK_PROG([HAVE_GCJ_IN_PATH], [gcj], [yes]) AC_CHECK_PROG([HAVE_JAVAC_IN_PATH], [javac], [yes]) AC_CHECK_PROG([HAVE_JIKES_IN_PATH], [jikes], [yes]) popdef([AC_MSG_RESULT])dnl - popdef([AC_CHECKING])dnl + popdef([AS_MESSAGE([checking ...])])dnl popdef([AC_MSG_CHECKING])dnl if test -z "$HAVE_JAVACOMP" && test -n "$HAVE_GCJ_IN_PATH"; then dnl Test for a good gcj version (>= 3.0). diff --git a/m4/javaexec.m4 b/m4/javaexec.m4 index c69575b85..83ed47455 100644 --- a/m4/javaexec.m4 +++ b/m4/javaexec.m4 @@ -28,14 +28,14 @@ AC_DEFUN([gt_JAVAEXEC], CONF_JAVA="$JAVA" else pushdef([AC_MSG_CHECKING],[:])dnl - pushdef([AC_CHECKING],[:])dnl + pushdef([AS_MESSAGE([checking ...])],[:])dnl pushdef([AC_MSG_RESULT],[:])dnl AC_CHECK_PROG([HAVE_GIJ_IN_PATH], [gij], [yes]) AC_CHECK_PROG([HAVE_JAVA_IN_PATH], [java], [yes]) AC_CHECK_PROG([HAVE_JRE_IN_PATH], [jre], [yes]) AC_CHECK_PROG([HAVE_JVIEW_IN_PATH], [jview], [yes]) popdef([AC_MSG_RESULT])dnl - popdef([AC_CHECKING])dnl + popdef([AS_MESSAGE([checking ...])])dnl popdef([AC_MSG_CHECKING])dnl m4_if([$1], , , [ save_CLASSPATH="$CLASSPATH" diff --git a/m4/malloc.m4 b/m4/malloc.m4 index c1f8ea32f..7b4faab96 100644 --- a/m4/malloc.m4 +++ b/m4/malloc.m4 @@ -8,7 +8,15 @@ dnl with or without modifications, as long as this notice is preserved. # https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=04be2b7a29d65d9a08e64e8e56e594c91749598c AC_DEFUN([_AC_FUNC_MALLOC_IF], [ - AC_REQUIRE([AC_HEADER_STDC])dnl + AC_REQUIRE([m4_warn([obsolete], +[The preprocessor macro `STDC_HEADERS' is obsolete. + Except in unusual embedded environments, you can safely include all + ISO C90 headers unconditionally.])dnl +# Autoupdate added the next two lines to ensure that your configure +# script's behavior did not change. They are probably safe to remove. +AC_CHECK_INCLUDES_DEFAULT +AC_PROG_EGREP +])dnl AC_REQUIRE([AC_CANONICAL_HOST])dnl for cross-compiles AC_CHECK_HEADERS([stdlib.h]) AC_CACHE_CHECK([for GNU libc compatible malloc], diff --git a/m4/realloc.m4 b/m4/realloc.m4 index 85b8f874f..4fb19d9ff 100644 --- a/m4/realloc.m4 +++ b/m4/realloc.m4 @@ -8,7 +8,15 @@ dnl with or without modifications, as long as this notice is preserved. # https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=04be2b7a29d65d9a08e64e8e56e594c91749598c AC_DEFUN([_AC_FUNC_REALLOC_IF], [ - AC_REQUIRE([AC_HEADER_STDC])dnl + AC_REQUIRE([m4_warn([obsolete], +[The preprocessor macro `STDC_HEADERS' is obsolete. + Except in unusual embedded environments, you can safely include all + ISO C90 headers unconditionally.])dnl +# Autoupdate added the next two lines to ensure that your configure +# script's behavior did not change. They are probably safe to remove. +AC_CHECK_INCLUDES_DEFAULT +AC_PROG_EGREP +])dnl AC_REQUIRE([AC_CANONICAL_HOST])dnl for cross-compiles AC_CHECK_HEADERS([stdlib.h]) AC_CACHE_CHECK([for GNU libc compatible realloc], diff --git a/m4/std-gnu11.m4 b/m4/std-gnu11.m4 index db833d820..a20d5b120 100644 --- a/m4/std-gnu11.m4 +++ b/m4/std-gnu11.m4 @@ -454,26 +454,50 @@ dnl preferably extc11. ])# _AC_PROG_CC_C11 -# AC_PROG_CC_C89 +# m4_warn([obsolete], +[AC_PROG_CC_C89 is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC) # -------------- -# Do not use AU_ALIAS here and in AC_PROG_CC_C99 and AC_PROG_CC_STDC, +# Do not use AU_ALIAS here and in m4_warn([obsolete], +[AC_PROG_CC_C99 is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC) and m4_warn([obsolete], +[AC_PROG_CC_STDC is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC), # as that'd be incompatible with how Automake redefines AC_PROG_CC. See # . -AU_DEFUN([AC_PROG_CC_C89], +AU_DEFUN([m4_warn([obsolete], +[AC_PROG_CC_C89 is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC)], [AC_REQUIRE([AC_PROG_CC])], [$0 is obsolete; use AC_PROG_CC] ) -# AC_PROG_CC_C99 +# m4_warn([obsolete], +[AC_PROG_CC_C99 is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC) # -------------- -AU_DEFUN([AC_PROG_CC_C99], +AU_DEFUN([m4_warn([obsolete], +[AC_PROG_CC_C99 is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC)], [AC_REQUIRE([AC_PROG_CC])], [$0 is obsolete; use AC_PROG_CC] ) -# AC_PROG_CC_STDC +# m4_warn([obsolete], +[AC_PROG_CC_STDC is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC) # --------------- -AU_DEFUN([AC_PROG_CC_STDC], +AU_DEFUN([m4_warn([obsolete], +[AC_PROG_CC_STDC is obsolete; use AC_PROG_CC +])dnl +AC_REQUIRE(AC_PROG_CC)], [AC_REQUIRE([AC_PROG_CC])], [$0 is obsolete; use AC_PROG_CC] ) diff --git a/m4/strsignal.m4 b/m4/strsignal.m4 index e8451fc78..3b1693040 100644 --- a/m4/strsignal.m4 +++ b/m4/strsignal.m4 @@ -54,6 +54,12 @@ AC_DEFUN([gl_FUNC_STRSIGNAL], # Prerequisites of lib/strsignal.c. AC_DEFUN([gl_PREREQ_STRSIGNAL], [ AC_CHECK_HEADERS_ONCE([unistd.h]) - AC_REQUIRE([AC_DECL_SYS_SIGLIST]) + AC_REQUIRE([AC_CHECK_DECLS([sys_siglist],[],[],[#include +/* NetBSD declares sys_siglist in unistd.h. */ +#ifdef HAVE_UNISTD_H +# include +#endif +]) +]) AC_CHECK_DECLS([_sys_siglist], [], [], [[#include ]]) ]) --eJnRUKwClWJh1Khz--