[PATCH] dfa: remove unused the member of structure

[PATCH] dfa: remove unused the member of structure

[Norihiro Tanaka]

[-- Attachment #1: Type: text/plain, Size: 95 bytes --]

Hi,

Now the member 'first_end' in struct dfa is used.
It should be removed.

Thanks,
Norihiro

[-- Attachment #2: 0001-dfa-remove-unused-the-member-of-structure.patch --]
[-- Type: text/plain, Size: 1930 bytes --]

From ce3f6337b651128d405137a58656e623579cf17d Mon Sep 17 00:00:00 2001
From: Norihiro Tanaka <noritnk@kcn.ne.jp>
Date: Sat, 26 Sep 2020 09:50:01 +0900
Subject: [PATCH] dfa: remove unused the member of structure

* lib/dfa.c (struct dfa): Remove unused member 'first_end'.
---
 lib/dfa.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/lib/dfa.c b/lib/dfa.c
index 4df5b00..74aafa2 100644
--- a/lib/dfa.c
+++ b/lib/dfa.c
@@ -370,7 +370,6 @@ typedef struct
   position_set elems;           /* Positions this state could match.  */
   unsigned char context;        /* Context from previous state.  */
   unsigned short constraint;    /* Constraint for this state to accept.  */
-  token first_end;              /* Token value of the first END in elems.  */
   position_set mbps;            /* Positions which can match multibyte
                                    characters or the follows, e.g., period.
                                    Used only if MB_CUR_MAX > 1.  */
@@ -2229,7 +2228,6 @@ state_index (struct dfa *d, position_set const *s, int context)
   size_t hash = 0;
   int constraint = 0;
   state_num i;
-  token first_end = 0;
 
   for (i = 0; i < s->nelem; ++i)
     {
@@ -2282,8 +2280,6 @@ state_index (struct dfa *d, position_set const *s, int context)
         {
           if (succeeds_in_context (c, context, CTX_ANY))
             constraint |= c;
-          if (!first_end)
-            first_end = d->tokens[s->elems[j].index];
         }
       else if (d->tokens[s->elems[j].index] == BACKREF)
         constraint = NO_CONSTRAINT;
@@ -2298,7 +2294,6 @@ state_index (struct dfa *d, position_set const *s, int context)
   copy (s, &d->states[i].elems);
   d->states[i].context = context;
   d->states[i].constraint = constraint;
-  d->states[i].first_end = first_end;
   d->states[i].mbps.nelem = 0;
   d->states[i].mbps.elems = NULL;
   d->states[i].mb_trindex = -1;
-- 
1.7.1

Re: [PATCH] dfa: remove unused the member of structure

[Paul Eggert]

Thanks. That patch is obviously harmless even at this late stage of grep 
testing, so I installed it into Gnulib where it can be picked up by the next 
gnulib update in grep.