From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1990F1F4B4 for ; Sun, 13 Sep 2020 19:22:40 +0000 (UTC) Received: from localhost ([::1]:37740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHXaA-0003aR-Pn for normalperson@yhbt.net; Sun, 13 Sep 2020 15:22:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXa4-0003a9-1X for bug-gnulib@gnu.org; Sun, 13 Sep 2020 15:22:32 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:35995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHXa2-0007Q3-H0 for bug-gnulib@gnu.org; Sun, 13 Sep 2020 15:22:31 -0400 Received: by mail-qk1-f193.google.com with SMTP id q63so14163388qkf.3 for ; Sun, 13 Sep 2020 12:22:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oTkj8oUhrJYzxUtsB3X3hwzrtBNvRr7gW3Hsf2cjybU=; b=b2Moglixd+850C7B7OMqBwe2BAq88I+4BLIZozMo11ffKWwu3u5PeYV41O/8SYxxuh 1MNMhGkZnCooRn86jNP3DmZ5Tiy2q1Iws2GUbvXE0ThrDDzBnY1Lv29GnhXnORasM9zG RdBFTe9RLyHYGxzYPAxR8k9VB+0KwZRHruDs9ArqaWnTz1gO5wnYONRT2klTmHw6lyb2 DS1stCrYwwgNynf0A/bG/TsxSLSJEpw5agMxHR4f2R2wGboDXN40m5NENaeymrXFieqE Ap9u/5HylAsgBcS/ztWPc1i0yAtjq9yKIfLkJ8/NqYyvdOGERCkeYoh0x2LtAKspBH54 2Dfg== X-Gm-Message-State: AOAM532yHnpw9Vn6CGsAD8JU8n8FdM8kTUS/RcTaDxay0QWO+jkxqh45 bndmlR5dlUpGlFmvCoNj8xQ= X-Google-Smtp-Source: ABdhPJxJY40DD72JuaUFLrtMMzaJ6p2rwODnM93NvCvMq3p1aEFvF3bKoUdi/vv4SZWLALIt0qyG9A== X-Received: by 2002:a05:620a:410:: with SMTP id 16mr9513554qkp.133.1600024949288; Sun, 13 Sep 2020 12:22:29 -0700 (PDT) Received: from sigxcpu.benpfaff.org ([2600:1700:9920:6b60:41d5:b917:88cd:c38d]) by smtp.gmail.com with ESMTPSA id r42sm12332158qtk.29.2020.09.13.12.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 12:22:28 -0700 (PDT) Date: Sun, 13 Sep 2020 12:22:26 -0700 From: Ben Pfaff To: Bruno Haible Subject: Re: [PATCH] getpass: Do not check for nonnull prompt argument in Win32 implementation. Message-ID: <20200913192226.GA3722784@sigxcpu.benpfaff.org> References: <20200912231030.2964126-1-blp@cs.stanford.edu> <2421457.Gk9qqdjgq8@omega> <20200913181047.GA3722105@sigxcpu.benpfaff.org> <3236931.FJ2QLDtgkl@omega> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3236931.FJ2QLDtgkl@omega> Received-SPF: pass client-ip=209.85.222.193; envelope-from=pfaffben@gmail.com; helo=mail-qk1-f193.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 14:10:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Josefsson , bug-gnulib@gnu.org, Jim Meyering Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Sun, Sep 13, 2020 at 09:05:32PM +0200, Bruno Haible wrote: > > 2020-09-12 Ben Pfaff > > > > Check for nonnull prompt argument while avoiding warnings. > > * lib/getpass.c (_GL_ARG_NONNULL): Define to empty. > > (getpass) [!_WIN32]: Print prompt only if nonnull. > > Looks good. Applied. Thank you!