bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Steve Lhomme <robux4@ycbcr.xyz>
To: bug-gnulib@gnu.org
Cc: Steve Lhomme <robux4@ycbcr.xyz>
Subject: [PATCH 1/2] stat: use a CHAR instead of TCHAR with GetFinalPathNameByHandleA
Date: Tue, 19 May 2020 08:26:09 +0200	[thread overview]
Message-ID: <20200519062610.8378-1-robux4@ycbcr.xyz> (raw)

The GetProcAddress uses the ANSI version of the API so the proper type for the
string is LPSTR, as found here:

https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfinalpathnamebyhandlea
---
 lib/stat-w32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/stat-w32.c b/lib/stat-w32.c
index 296ccf18c..106d25120 100644
--- a/lib/stat-w32.c
+++ b/lib/stat-w32.c
@@ -52,7 +52,7 @@ static GetFileInformationByHandleExFuncType GetFileInformationByHandleExFunc = N
 #endif
 /* GetFinalPathNameByHandle was introduced only in Windows Vista.  */
 typedef DWORD (WINAPI * GetFinalPathNameByHandleFuncType) (HANDLE hFile,
-                                                           LPTSTR lpFilePath,
+                                                           LPSTR lpFilePath,
                                                            DWORD lenFilePath,
                                                            DWORD dwFlags);
 static GetFinalPathNameByHandleFuncType GetFinalPathNameByHandleFunc = NULL;
-- 
2.26.2



             reply	other threads:[~2020-05-19  6:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  6:26 Steve Lhomme [this message]
2020-05-19  6:26 ` [PATCH 2/2] stat: do not use LoadLibrary when built for Windows Store apps Steve Lhomme
2020-05-28  6:26   ` Steve Lhomme
2020-05-30  9:21   ` Bruno Haible
2020-05-28  0:43 ` [PATCH 1/2] stat: use a CHAR instead of TCHAR with GetFinalPathNameByHandleA Bruno Haible
2020-05-28  1:07   ` Jeffrey Walton
2020-05-30  9:16   ` Don't assume that UNICODE is not defined Bruno Haible
2020-05-30 10:57     ` Jeffrey Walton
2020-05-30 12:43       ` Steve Lhomme
2020-05-30 12:46     ` Steve Lhomme
2020-05-30 14:31       ` Bruno Haible
2020-05-30 14:46         ` Steve Lhomme
2020-05-30 15:43           ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519062610.8378-1-robux4@ycbcr.xyz \
    --to=robux4@ycbcr.xyz \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).