From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 95AC61F463 for ; Fri, 13 Dec 2019 08:10:19 +0000 (UTC) Received: from localhost ([::1]:42096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifg1i-0007Q8-9U for normalperson@yhbt.net; Fri, 13 Dec 2019 03:10:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55739) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifg1c-0007Pz-2j for bug-gnulib@gnu.org; Fri, 13 Dec 2019 03:10:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifg1a-0002wO-TM for bug-gnulib@gnu.org; Fri, 13 Dec 2019 03:10:11 -0500 Received: from freefriends.org ([96.88.95.60]:45332) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifg1a-0002uE-Kx for bug-gnulib@gnu.org; Fri, 13 Dec 2019 03:10:10 -0500 X-Envelope-From: arnold@skeeve.com Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id xBD89whI021731 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Dec 2019 01:09:58 -0700 Received: (from arnold@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id xBD89uUG021729; Fri, 13 Dec 2019 01:09:56 -0700 From: arnold@skeeve.com Message-Id: <201912130809.xBD89uUG021729@freefriends.org> X-Authentication-Warning: frenzy.freefriends.org: arnold set sender to arnold@skeeve.com using -f Date: Fri, 13 Dec 2019 01:09:56 -0700 To: noritnk@kcn.ne.jp, eggert@cs.ucla.edu, arnold@skeeve.com, 34951@debbugs.gnu.org Subject: Re: bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher References: <20190323080618.E6EB.27F6AC2D@kcn.ne.jp> <20190323114902.E6F6.27F6AC2D@kcn.ne.jp> <75091466-e105-c35c-fcd6-19ccca325914@cs.ucla.edu> <201912120731.xBC7V6gD031767@freefriends.org> <38194689-56ba-41f4-3810-50df1ff9019c@cs.ucla.edu> In-Reply-To: <38194689-56ba-41f4-3810-50df1ff9019c@cs.ucla.edu> User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 96.88.95.60 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Paul. Paul Eggert wrote: > On 12/11/19 11:31 PM, arnold@skeeve.com wrote: > > > 1,$s/ptrdiff_t/ssize_t/g > > ssize_t can be narrower than ptrdiff_t, so it's not a good type to use > for this notion. Its original motivation was "the type that 'read' > returns", and on systems where 'read' can return at most INT_MAX, > ssize_t can be 32 bits even if size_t is 64 bits. In practice, how many system are there where ssize_t is 32 bits and size_t is 64? If that number is <= 5 then I wouldn't worry about using ssize_t. In any case, as I said, I can live with ptrdiff_t in the implementation, even though I don't like it that much. (A nice block comment at the top of dfa.c explaining why ptrdiff_t is used would be appropriate.) But I really don't want ptrdiff_t in the API. Thanks, Arnold Thanks, Arnold