From: arnold@skeeve.com
To: noritnk@kcn.ne.jp, eggert@cs.ucla.edu, 34951@debbugs.gnu.org
Cc: arnold@skeeve.com, bug-gnulib@gnu.org
Subject: Re: bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher
Date: Thu, 12 Dec 2019 00:23:06 -0700 [thread overview]
Message-ID: <201912120723.xBC7N62j031361@freefriends.org> (raw)
In-Reply-To: <75091466-e105-c35c-fcd6-19ccca325914@cs.ucla.edu>
Hi Paul.
Paul Eggert <eggert@cs.ucla.edu> wrote:
> On 3/22/19 7:49 PM, Norihiro Tanaka wrote:
> > Missing a patch for dfa. Re-send correct patch file.
>
> Thanks, I installed the DFA-relevant parts of your proposed fix into
> Gnulib. (The grep parts still need doing.) I also installed the attached
> commentary followup.
>
> While I was at it I installed a patch to fix an unlikely integer
> overflow that I noticed while reviewing your fix. I also installed some
> internal changes to prefer signed to unsigned integers for indexes, as
> this should make future integer overflows easier to catch. See:
>
> https://lists.gnu.org/r/bug-gnulib/2019-12/msg00058.html
> https://lists.gnu.org/r/bug-gnulib/2019-12/msg00059.html
I am reviewing these. In general using signed integers internally
looks OK to me.
> I'd also like to change dfa.h's API to prefer ptrdiff_t to size_t, for
> the same integer-overflow reason. This would be a (minor) API change so
> I thought I'd ask first. Any objections?
Yes. I object. Strongly.
We're passing length and count values and those are supposed
to be size_t. If you REALLY want signed values, then I could
live with ssize_t (as returned by read(2), for example), but I
would find ptrdiff_t to be ugly and unintuitive.
> PS. Arnold, the above discusses all the changes I know about for dfa.c
> and dfa.h. The proposed API change (size_t->ptrdiff_t) could be
> installed either before or after the next Gawk release.
Thanks. I'm skimming the other changes now.
Arnold
next prev parent reply other threads:[~2019-12-12 7:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 23:06 [PATCH] grep: a kwset matcher not work in a grep matcher Norihiro Tanaka
2019-03-23 2:49 ` bug#34951: " Norihiro Tanaka
2019-03-23 2:58 ` Budi
2019-03-23 2:59 ` Budi
2019-03-23 12:39 ` Eric Blake
2019-03-29 10:58 ` arnold
2019-12-11 23:25 ` Paul Eggert
2019-12-12 7:23 ` arnold [this message]
2019-12-12 7:31 ` arnold
2019-12-12 7:47 ` arnold
2019-12-12 22:26 ` Paul Eggert
2019-12-13 8:09 ` arnold
2019-12-13 12:08 ` arnold
2019-12-13 17:53 ` Jim Meyering
2019-12-13 20:00 ` Paul Eggert
2019-12-14 2:35 ` intptr_t vs. uintptr_t Bruno Haible
2019-12-14 3:19 ` Paul Eggert
2019-12-14 9:14 ` Bruno Haible
2019-12-14 22:29 ` Paul Eggert
2019-12-15 0:35 ` Bruno Haible
2019-12-16 10:02 ` Paul Eggert
2019-12-15 8:14 ` bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher arnold
2019-12-16 9:56 ` Paul Eggert
2019-12-16 10:12 ` arnold
2019-12-20 3:18 ` Paul Eggert
2019-12-20 10:35 ` arnold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912120723.xBC7N62j031361@freefriends.org \
--to=arnold@skeeve.com \
--cc=34951@debbugs.gnu.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=noritnk@kcn.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).