bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bernhard Voelker <INVALID.NOREPLY@gnu.org>
To: Martin Liška <mliska@suse.cz>,
	Bernhard Voelker <mail@bernhard-voelker.de>,
	bug-gnulib@gnu.org, bug-findutils@gnu.org
Subject: [bug #57277] FAIL: test-canonicalize-lgpl with GCC 10
Date: Wed, 20 Nov 2019 18:49:55 -0500 (EST)	[thread overview]
Message-ID: <20191121-004954.sv89737.17322@savannah.gnu.org> (raw)
In-Reply-To: <20191120-145521.sv108124.86413@savannah.gnu.org>

Follow-up Comment #1, bug #57277 (project findutils):

First of all, the fix for this should go into gnulib --> adding their ML.

Then, this test actually wants to verify the behavior of that
function when called with a NULL value (it should return NULL
and set errno to EINVAL).
Therefore, the test needs to suppress that specific sanitizer
error. I don't have a GCC 10, so does something like the
following work?


a/tests/test-canonicalize-lgpl.c b/tests/test-canonicalize-lgpl.c
index 4ce06e46c..4e7d47c57 100644
--- a/tests/test-canonicalize-lgpl.c
+++ b/tests/test-canonicalize-lgpl.c
@@ -39,6 +39,9 @@ SIGNATURE_CHECK (canonicalize_file_name, char *, (const char
*));
 
 #define BASE "t-can-lgpl.tmp"
 
+/* Suppress -fsanitize=null error - seen on GCC 10 - for this test.  */
+extern char *canonicalize_file_name (const char *)
__attribute__((no_sanitize("null")));
+
 int
 main (void)
 {


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57277>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/



       reply	other threads:[~2019-11-20 23:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191120-145521.sv108124.86413@savannah.gnu.org>
2019-11-20 23:49 ` Bernhard Voelker [this message]
2019-11-21  2:15   ` [bug #57277] FAIL: test-canonicalize-lgpl with GCC 10 Bruno Haible
2019-11-21  9:37     ` Martin Liška
2019-11-21 11:07       ` Bruno Haible
2020-01-05 22:53         ` Bruno Haible
2020-01-06  0:46           ` Bernhard Voelker
2020-01-06 13:06             ` Bernhard Voelker
2021-01-09 15:20               ` Bernhard Voelker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191121-004954.sv89737.17322@savannah.gnu.org \
    --to=invalid.noreply@gnu.org \
    --cc=bug-findutils@gnu.org \
    --cc=bug-gnulib@gnu.org \
    --cc=mail@bernhard-voelker.de \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).