From: Darshit Shah <darnir@gnu.org>
To: Jim Meyering <jim@meyering.net>
Cc: "bug-gnulib@gnu.org List" <bug-gnulib@gnu.org>
Subject: Re: sc_prohibit_magic_number_exit false positive on string
Date: Wed, 11 Sep 2019 18:23:04 +0200 [thread overview]
Message-ID: <20190911162303.jgqqju6qzl3vjocp@tardis.localdomain> (raw)
In-Reply-To: <CA+8g5KErj0BrwFeJrEUEdT=reegkAA_WPu66BKo0GR_MydK8XA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]
* Jim Meyering <jim@meyering.net> [190908 17:19]:
> On Sun, Sep 8, 2019 at 6:06 AM Darshit Shah <darnir@gnu.org> wrote:
> > I just realized that the syntax check rule sc_prohibit_magic_number_exit will
> > cause a false positive when it finds the relevant tokens within a string as
> > well.
> >
> > For example, in Wget, we have the following snippet in our tests which trips
> > this rule:
> >
> > > WGET_TEST_EXPECTED_FILES, &(wget_test_file_t []) {
> > > { "exit-status.txt", "exit(8)\n" },
> > > { NULL } },
> >
> > I made a very tiny change to the rule in maint.mk(L408) to account for this:
> >
> > -exclude='exit \(77\)|error ?\(((0|77),|[^,]*)' \
> > +exclude='exit \(77\)|error ?\(((0|77),|[^,]*)|"(usage|exit|error).*"' \
>
> Hi Darshit, that feels a little too specific.
> Did you consider exempting that file from this one check?
> You can do that by adding a line like the following to cfg.mk:
>
> exclude_file_name_regexp--sc_prohibit_magic_number_exit =
> offending-file-regexp\.c$$
I agree that my solution is a little too specific. I did not intend for it to
be applied as-is. However, I think it makes sense that the syntax-check rules
check to make sure that the token is not found within a string.
Ideally, you'd update the except regex like I did to check if it's a string
literal, a comment or multi-line variants of those.
--
Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 894 bytes --]
prev parent reply other threads:[~2019-09-11 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 12:56 sc_prohibit_magic_number_exit false positive on string Darshit Shah
2019-09-08 15:19 ` Jim Meyering
2019-09-11 16:23 ` Darshit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911162303.jgqqju6qzl3vjocp@tardis.localdomain \
--to=darnir@gnu.org \
--cc=bug-gnulib@gnu.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).