From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6E55E1F45F for ; Mon, 6 May 2019 18:44:01 +0000 (UTC) Received: from localhost ([127.0.0.1]:60779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNial-0004K3-Q4 for normalperson@yhbt.net; Mon, 06 May 2019 14:43:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNiah-0004Jy-J9 for bug-gnulib@gnu.org; Mon, 06 May 2019 14:43:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNiag-0006Gq-L4 for bug-gnulib@gnu.org; Mon, 06 May 2019 14:43:55 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNiag-0006FI-FL for bug-gnulib@gnu.org; Mon, 06 May 2019 14:43:54 -0400 Received: by mail-pg1-f194.google.com with SMTP id c13so6902091pgt.1 for ; Mon, 06 May 2019 11:43:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pvyExTFCQubQR59W+FidU3WibKc5MFtHEF7doLBUutg=; b=pzRFNziPKtIsh3ZgV3+XtFG88xJ4sPnJdCbvKqx7BLzL7jF8xyGPu2nfId0cs8jlO3 9queeoCqKeUYxFxGvQglBXjoNCPEBB13zRKojxmzSuCUQhrP1XQsj83tPOjsjXER/KoR S5AYjxLQBeEUG0aE5K0pW7G7kkRxu0J4WUzQq4RoYRcfZi4gu7Hfd8fJpZs/pbtzF4Qk pD+9gl9z87Lh0fByFi88LkmQn5V3fLs4sAi9jP2mYYZQHdHSC6giuawhjOil/mfxaR+O 5Ve8xzn0u4T5c/6vTcvtQeuLvLIQ6RCxOnzcKD1zCwRJXbu7gqOKiWvwME50cdateNXJ UoxQ== X-Gm-Message-State: APjAAAXgqPvzvrzUput1Xfb/+S46fyrbMfJ8Y7xJ2XoAarBmZN91xjpy rdYocYnS2Dog/l8uc3+a7A8= X-Google-Smtp-Source: APXvYqwS3ZP9LWMLXOxLnSOoCwtcLvNs//BKWuNKQbpqtY0cjlT9A++zeN57lDB/i+7lvVOBUOPSDw== X-Received: by 2002:a62:4602:: with SMTP id t2mr35387265pfa.26.1557168231901; Mon, 06 May 2019 11:43:51 -0700 (PDT) Received: from sigabrt.benpfaff.org ([66.170.99.95]) by smtp.gmail.com with ESMTPSA id z66sm20836594pfz.83.2019.05.06.11.43.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 May 2019 11:43:51 -0700 (PDT) Date: Mon, 6 May 2019 11:43:49 -0700 From: Ben Pfaff To: John Darrington Subject: Re: [PATCH] version-etc.c: Do not include URLS in translatable strings. Message-ID: <20190506184349.GM4154@sigabrt.benpfaff.org> References: <20190506182134.4347-1-john@darrington.wattle.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190506182134.4347-1-john@darrington.wattle.id.au> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.215.194 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Mon, May 06, 2019 at 08:21:34PM +0200, John Darrington wrote: > This method is better for several reasons: 1. It avoids the danger of > cut and paste errors. 2. Naive translators can't translate the urls > (it's amazing how many do things like that!) 3. Should the urls ever > change, only this file has to be updated rather than every single > translation. > > * lib/version-etc.c: Take URLS out of translatable strings. > --- > lib/version-etc.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/lib/version-etc.c b/lib/version-etc.c > index 9ca9a5628..4a060e0b5 100644 > --- a/lib/version-etc.c > +++ b/lib/version-etc.c > @@ -82,14 +82,13 @@ version_etc_arn (FILE *stream, > locale. Otherwise, do not translate "(C)"; leave it as-is. */ > fprintf (stream, version_etc_copyright, _("(C)"), COPYRIGHT_YEAR); > > - fputs (_("\ > + fprintf (stream, _("\ > \n\ > -License GPLv3+: GNU GPL version 3 or later .\n\ > +License GPLv3+: GNU GPL version 3 or later <%s>.\n\ Does anyone ever try to translate the "GPLv3+" part? If so, then it could be taken out as well.