bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Bruno Haible <bruno@clisp.org>
Cc: Gnulib bugs <bug-gnulib@gnu.org>
Subject: Re: single-threaded optimizations
Date: Sun, 7 Mar 2021 18:46:25 -0800	[thread overview]
Message-ID: <19ba1ebf-3a18-cef2-8a89-e9446571201b@cs.ucla.edu> (raw)
In-Reply-To: <2783771.9LmcWK8fO3@omega>

On 3/7/21 1:58 AM, Bruno Haible wrote:
> The mbrtowc modules states:
> 
>    Link:
>    $(LIB_MBRTOWC)

Thanks for explaining that. Over time Gnulib has evolved and 'tar' 
hadn't caught up with all those Link: lines. So I just now added 
$(LIB_ACL), $(LIB_GETRANDOM), $(LIB_HARD_LOCALE), $(LIB_HAS_ACL), 
$(LIB_MBRTOWC), and $(LIB_SETLOCALE_NULL) to the tar linking instructions.

However, I have a new problem now. Even though 'tar' now defines 
GNULIB_EXCLUDE_SINGLE_THREAD, GNULIB_MBRTOWC_SINGLE_THREAD, 
GNULIB_REGEX_SINGLE_THREAD, and GNULIB_WCHAR_SINGLE_LOCALE, 'configure' 
still unnecessarily arranges for GNU Tar to be linked with -lpthread, 
because of these lines in src/Makefile:

LIB_HARD_LOCALE = -lpthread
LIB_MBRTOWC = -lpthread
LIB_SETLOCALE_NULL = -lpthread

I can work around this unnecessary dynamic dependency for GNU Tar by 
removing $(LIB_HARD_LOCALE), $(LIB_MBRTOWC) and $(LIB_SETLOCALE_NULL) 
from the tar linking instructions. But this seems brittle, as these 
$(LIB_...) macros might expand to something other than a threading 
library in the future. Is there a better way?


      parent reply	other threads:[~2021-03-08  2:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  0:28 [PATCH] mbrtowc: port to AIX 7.1 with xlc 12.1 Paul Eggert
2021-03-03  3:27 ` single-threaded optimizations Bruno Haible
2021-03-06 16:56   ` Paul Eggert
2021-03-07  9:58     ` Bruno Haible
2021-03-07 10:03       ` Bruno Haible
2021-03-08  2:46       ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19ba1ebf-3a18-cef2-8a89-e9446571201b@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).