From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 263FA1F47C for ; Tue, 17 Jan 2023 21:16:24 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=V3ZlodM4; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHtJR-0001Hj-1v; Tue, 17 Jan 2023 16:16:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHtJN-0001Bo-IW for bug-gnulib@gnu.org; Tue, 17 Jan 2023 16:16:06 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHtJJ-00084d-4C for bug-gnulib@gnu.org; Tue, 17 Jan 2023 16:16:05 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1673990155; cv=none; d=strato.com; s=strato-dkim-0002; b=PbeyX/WMfWv3rLxeiAhiWBL6Qt9TVJQ0ppqrjvtpg5A9Do3s1c4wBafJSEz2sS06W5 G5e3PggWeakclkgkYhTJ0RMkJA3rKDMMrgyVDNhWVAa+My1EwTr402UEF9maijbbHYjX QDq3nYXA/o4+qsIV4JNKIGkdzE4APw6asnqB7lD0dNibAX6rnVkdO9vre/CU1fs/TJtl YJ+5zblcsEyCki1WCuPMzzy+taTOiH68YuJE+G/0krEHqoOFt+5MGrgMt1rZSJK9ihcT uZ9kWz9IUoCahTFGM+TU39UjIUtuCwzsyXl1YXoGdIwuCBtimbwg1IT/eWzr6hmQzuX0 fO2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1673990155; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=oHsZ4hCJqjk9/rtK3iw4u8a9ao1PZ55RwLzWS3K8gLk=; b=Anwn9GXGnywLvzfWOJ8vWAX4UaMR97SW0Rll5AnTvNwTTJHeeoSvrP81na+QPKMJUX 1XSUJWUENjUZdtTwztk+N6OPPNhrM/0gLoSJDMd6WHe84F9xEX7DpaGf1R9nfxXlTqlv R0k0uvo1LVDnYCLxdNJd53J6CotkMGeU21YWAMsLs50e9zJ/JxgNo6FLrdpdfM9/uYr8 OK/+UB4fmFTGbqoRBaukHIJckoYtpx2XNILhSiVyaFFp/07qbzf3vJV7M/eefQZkMLRx uME5WkdYDKPSMz4deTow6jr9CVT55lbZjH14a8rHWxPB9J3bMX0BlippLbfjmljftZg/ +/nA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1673990155; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=oHsZ4hCJqjk9/rtK3iw4u8a9ao1PZ55RwLzWS3K8gLk=; b=V3ZlodM4im8/1rQ+5N2g1vq/Rs62iPgsMbw/rCBPwDJlFajyUbpH9tQjgscQdAz9WA 1Kt679HagxPOHyB654rHUA63FcAFcb+4JKysOY5wCS8zka2YMzxXV0L38Dehkt7F8hyg 57uJQiF2P1jz4jVHNNHO9/l/eOTNYUjkuQ9/NkdNhQs3ESMq/hMu8OREWRcgyYmKZtnU 0nAMj51MQL+SPus7vGfq5zZcCWDj2c2mmRnkIr7mI8Bzc8YdMMe3iGzQz7jTRuQMGDIl 7HQmSJveVnvHdDmBty+axS0xgbnKOuTAs+LK9uJgUtICNNcy8K4YdFnI0ZDkfH11EI+G JF/g== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOU36ZlyvfpaYudzZv7Hx1QQv/ySQ==" Received: from nimes.localnet by smtp.strato.de (RZmta 48.6.2 AUTH) with ESMTPSA id I8f358z0HLFtVO9 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 17 Jan 2023 22:15:55 +0100 (CET) From: Bruno Haible To: Eric Blake Cc: bug-gnulib@gnu.org Subject: Re: execute tests: Avoid test failure on Android Date: Tue, 17 Jan 2023 22:15:54 +0100 Message-ID: <1982183.1Y0LTTvt8K@nimes> In-Reply-To: <20230117194201.mt6hsgxxwyjoyusv@redhat.com> References: <4520176.VQJxnDRnGh@nimes> <20230117194201.mt6hsgxxwyjoyusv@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.163; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Eric Blake wrote: > > Apparently the SIGPIPE handler gets set to SIG_IGN, either by 'make' or > > by the test-driver. > > Known regression in make 4.4: > https://savannah.gnu.org/bugs/index.php?63307 Thanks. Indeed, I can reproduce the test failure also on a glibc system, with make 4.4 in $PATH. Thus I'm generalizing the workaround: 2023-01-17 Bruno Haible execute tests: Avoid test failure with GNU make 4.4. Reported by Eric Blake in . * tests/test-execute-main.c (main): Reset the SIGPIPE handler to default on all platforms. diff --git a/tests/test-execute-main.c b/tests/test-execute-main.c index fbaa9c9d2e..2088408756 100644 --- a/tests/test-execute-main.c +++ b/tests/test-execute-main.c @@ -58,17 +58,16 @@ main (int argc, char *argv[]) const char *progname = "test-execute-child"; int test = atoi (argv[2]); -#if defined __ANDROID__ - /* On Android 11, when this test is executed through 'make' (GNU make 4.4) and + /* When this test is executed through 'make' (GNU make 4.4) and build-aux/test-driver, i.e. through make check TESTS=test-execute.sh or rm -f test-execute.sh.log; make test-execute.sh.log - the signal handler for SIGPIPE is set to SIG_IGN. This causes the tests - 3 and 4 to fail. Work around it by resetting the signal handler for - SIGPIPE to the default. */ + the signal handler for SIGPIPE is set to SIG_IGN. This is a bug in + GNU make 4.4: . + It causes the tests 3 and 4 to fail. Work around it by resetting + the signal handler for SIGPIPE to the default. */ signal (SIGPIPE, SIG_DFL); -#endif switch (test) {