From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Gnulib's alloca.h and MinGW
Date: Tue, 30 Jun 2020 00:55:49 +0200 [thread overview]
Message-ID: <1928030.008H2qJTyv@omega> (raw)
In-Reply-To: <83d05h2361.fsf@gnu.org>
Hi Eli,
> A recent MinGW runtime changed its definition of alloca from an
> inline function to a macro. As result, there's a warning when
> compiling Gnulib's malloca.c:
>
> CC malloca.o
> In file included from malloca.h:21,
> from malloca.c:22:
> ./alloca.h:46: warning: "alloca" redefined
> 46 | # define alloca __builtin_alloca
> |
> In file included from ./alloca.h:44,
> from malloca.h:21,
> from malloca.c:22:
> d:\usr\include\alloca.h:81: note: this is the location of the previous definition
> 81 | #define alloca( __request ) __builtin_alloca( __request )
> |
>
> Proposed patch is below. Thanks.
Thanks for the report.
I like your patch. It is better than the '#undef alloca' solution that I
had considered before.
2020-06-29 Bruno Haible <bruno@clisp.org>
alloca-opt: Fix warning on mingw.
Reported and solution by Eli Zaretskii <eliz@gnu.org> in
<https://lists.gnu.org/archive/html/bug-gnulib/2020-06/msg00069.html>.
* lib/alloca.in.h: On mingw, include <alloca.h> and then test again
whether alloca is defined.
diff --git a/lib/alloca.in.h b/lib/alloca.in.h
index 73516ca..beb022c 100644
--- a/lib/alloca.in.h
+++ b/lib/alloca.in.h
@@ -35,13 +35,16 @@
*/
#ifndef alloca
+ /* Some version of mingw have an <alloca.h> that causes trouble when
+ included after 'alloca' gets defined as a macro. As a workaround,
+ include this <alloca.h> first and define 'alloca' as a macro afterwards
+ if needed. */
+# if defined __GNUC__ && (defined _WIN32 && ! defined __CYGWIN__) && @HAVE_ALLOCA_H@
+# include_next <alloca.h>
+# endif
+#endif
+#ifndef alloca
# ifdef __GNUC__
- /* Some version of mingw have an <alloca.h> that causes trouble when
- included after 'alloca' gets defined as a macro. As a workaround, include
- this <alloca.h> first and define 'alloca' as a macro afterwards. */
-# if (defined _WIN32 && ! defined __CYGWIN__) && @HAVE_ALLOCA_H@
-# include_next <alloca.h>
-# endif
# define alloca __builtin_alloca
# elif defined _AIX
# define alloca __alloca
next prev parent reply other threads:[~2020-06-29 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 17:27 Gnulib's alloca.h and MinGW Eli Zaretskii
2020-06-29 22:55 ` Bruno Haible [this message]
2020-06-30 2:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1928030.008H2qJTyv@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).