From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B5A601F5AE for ; Sat, 27 Jun 2020 10:19:39 +0000 (UTC) Received: from localhost ([::1]:34866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jp7vu-0002y6-Ir for normalperson@yhbt.net; Sat, 27 Jun 2020 06:19:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jp7vs-0002y0-7x for bug-gnulib@gnu.org; Sat, 27 Jun 2020 06:19:36 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.25]:14192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jp7vp-0005Go-1k for bug-gnulib@gnu.org; Sat, 27 Jun 2020 06:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1593253170; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=rs88Xqokhl4qqiMkSbqFjObeJlp/4T3HZgMROu/E1lg=; b=h9n4Yl5jiAKDWsX8tnz5pEf6Ljhzyq4pqCUKVbfzeJCT5YwDUcYzD/fcx82uZgERNQ DVMOVsCzPPxRGD2CjFGwA1TJxc7rPJLNPrjGB12vPeGy2aGMy/hPEjf6yasqc0C3cEk9 mXM4HTWwTBH8JTNMfL9ogrUCvSxuFqQrGmyvAV6XSBNlzkoZ35FbTuqMaZQcM1CanLhz ouRr6kamgpDP0qMQPZrWzhBayeFCI4og9TK7PH6t/CuhWZ5MBMMv4nVoJOhItYRTeSvO fx91/6US0lv1f4Z+BLUvaBNybhRY55krA3kTSrfSlf0BZcPZPOxs54t7BlSe6/1s7qWV uldw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.10.5 DYNA|AUTH) with ESMTPSA id R03d1aw5RAJJLHV (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sat, 27 Jun 2020 12:19:19 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: [PATCH] tempname: merge from glibc and coreutils Date: Sat, 27 Jun 2020 12:19:18 +0200 Message-ID: <1889054.g1QTsAqMDn@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-179-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20200601051713.12911-1-eggert@cs.ucla.edu> References: <20200601051713.12911-1-eggert@cs.ucla.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.25; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/27 06:19:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Eggert Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Paul Eggert wrote on 2020-05-31: > * modules/tempname (Depends-on): Remove gettimeofday, sys_time. > Add getentropy, libc-config. On MSVC, this produces a link error in programs that use this module, because of the function BCryptGenRandom. Such programs now need to link with $(LIB_GETRANDOM). Likewise for some modules which depend on 'tempname'. Here is the reverse dependency tree: getrandom <- tempname <- mkdtemp <- clean-temp <- javacomp <- mkstemp <- stdlib-safer <- mkstemps <- mkostemp <- mkostemps <- tmpfile <- tmpfile-safer <- argv-iter-tests 2020-06-27 Bruno Haible tempname et al.: Fix link errors on MSVC (regression from 2020-05-31). * modules/tempname (Link): New section. * modules/mkdtemp (Link): Likewise. * modules/clean-temp (Link): Likewise. * modules/mkstemp (Link): Likewise. * modules/stdlib-safer (Link): Likewise. * modules/mkstemps (Link): Likewise. * modules/mkostemp (Link): Likewise. * modules/mkostemps (Link): Likewise. * modules/tmpfile (Link): Likewise. * modules/tmpfile-safer (Link): Likewise. * modules/javacomp (Link): Add $(LIB_GETRANDOM). * modules/argv-iter-tests (Makefile.am): Link test-argv-iter with $(LIB_GETRANDOM). * NEWS: Mention the changes. diff --git a/NEWS b/NEWS index c8f78ea..5684494 100644 --- a/NEWS +++ b/NEWS @@ -58,6 +58,19 @@ User visible incompatible changes Date Modules Changes +2020-06-27 tempname The link requirements of these modules are changed + mkdtemp from empty to $(LIB_GETRANDOM). + mkstemp + mkstemps + mkostemp + mkostemps + tmpfile + stdlib-safer + tmpfile-safer + clean-temp + javacomp $(LIB_GETRANDOM) was added to the link requirements + of this module. + 2020-05-27 read-file The functions provided by this module now take an 'int flags' argument to modify the file reading behavior. The read_binary_file function has been diff --git a/modules/argv-iter-tests b/modules/argv-iter-tests index f32587e..97cbe50 100644 --- a/modules/argv-iter-tests +++ b/modules/argv-iter-tests @@ -10,3 +10,4 @@ configure.ac: Makefile.am: TESTS += test-argv-iter check_PROGRAMS += test-argv-iter +test_argv_iter_LDADD = $(LDADD) $(LIB_GETRANDOM) diff --git a/modules/clean-temp b/modules/clean-temp index d5c44ee..abed9b9 100644 --- a/modules/clean-temp +++ b/modules/clean-temp @@ -31,6 +31,9 @@ lib_SOURCES += clean-temp.h clean-temp.c Include: "clean-temp.h" +Link: +$(LIB_GETRANDOM) + License: GPL diff --git a/modules/javacomp b/modules/javacomp index 0552797..5f8f60f 100644 --- a/modules/javacomp +++ b/modules/javacomp @@ -43,6 +43,7 @@ Include: Link: $(LIB_MBRTOWC) +$(LIB_GETRANDOM) License: GPL diff --git a/modules/mkdtemp b/modules/mkdtemp index 3bd83e2..13b2d5a 100644 --- a/modules/mkdtemp +++ b/modules/mkdtemp @@ -23,6 +23,9 @@ Makefile.am: Include: +Link: +$(LIB_GETRANDOM) + License: LGPLv2+ diff --git a/modules/mkostemp b/modules/mkostemp index afa49d6..460e842 100644 --- a/modules/mkostemp +++ b/modules/mkostemp @@ -26,6 +26,9 @@ Makefile.am: Include: +Link: +$(LIB_GETRANDOM) + License: LGPLv2+ diff --git a/modules/mkostemps b/modules/mkostemps index fb956f9..bb9fe71 100644 --- a/modules/mkostemps +++ b/modules/mkostemps @@ -25,6 +25,9 @@ Makefile.am: Include: +Link: +$(LIB_GETRANDOM) + License: LGPLv2+ diff --git a/modules/mkstemp b/modules/mkstemp index 780908f..d985715 100644 --- a/modules/mkstemp +++ b/modules/mkstemp @@ -24,6 +24,9 @@ Makefile.am: Include: +Link: +$(LIB_GETRANDOM) + License: LGPLv2+ diff --git a/modules/mkstemps b/modules/mkstemps index 61af8d5..1e5f097 100644 --- a/modules/mkstemps +++ b/modules/mkstemps @@ -24,6 +24,9 @@ Makefile.am: Include: +Link: +$(LIB_GETRANDOM) + License: LGPLv2+ diff --git a/modules/stdlib-safer b/modules/stdlib-safer index 8dbd682..80414b3 100644 --- a/modules/stdlib-safer +++ b/modules/stdlib-safer @@ -20,6 +20,9 @@ lib_SOURCES += mkstemp-safer.c Include: "stdlib-safer.h" +Link: +$(LIB_GETRANDOM) + License: GPL diff --git a/modules/tempname b/modules/tempname index 0f692d3..ca88522 100644 --- a/modules/tempname +++ b/modules/tempname @@ -26,6 +26,9 @@ lib_SOURCES += tempname.c Include: "tempname.h" +Link: +$(LIB_GETRANDOM) + License: LGPLv2+ diff --git a/modules/tmpfile b/modules/tmpfile index 884f284..20b88c8 100644 --- a/modules/tmpfile +++ b/modules/tmpfile @@ -26,6 +26,9 @@ Makefile.am: Include: +Link: +$(LIB_GETRANDOM) + License: LGPL diff --git a/modules/tmpfile-safer b/modules/tmpfile-safer index d63559e..02e49d4 100644 --- a/modules/tmpfile-safer +++ b/modules/tmpfile-safer @@ -20,6 +20,9 @@ lib_SOURCES += tmpfile-safer.c Include: "stdio-safer.h" +Link: +$(LIB_GETRANDOM) + License: GPL