bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: James Youngman <jay@gnu.org>
Subject: Re: [PATCH] Make it possible to call canonicalize_filename_mode from C++.
Date: Tue, 28 May 2019 23:06:45 +0200	[thread overview]
Message-ID: <1879324.D8i1emut2y@omega> (raw)
In-Reply-To: <20190528122116.2220-1-jay@gnu.org>

Hi James,

> diff --git a/lib/canonicalize.h b/lib/canonicalize.h
> index 2ffa1f681..d21b5b203 100644
> --- a/lib/canonicalize.h
> +++ b/lib/canonicalize.h
> @@ -21,6 +21,10 @@
>  
>  #define CAN_MODE_MASK (CAN_EXISTING | CAN_ALL_BUT_LAST | CAN_MISSING)
>  
> +# ifdef __cplusplus
> +extern "C" {
> +# endif
> +
>  enum canonicalize_mode_t
>    {
>      /* All components must exist.  */
> ...

Thanks, applied (with no space after '#', to keep the indentation consistent
in the file).

Likewise for the second patch.

Bruno



      reply	other threads:[~2019-05-28 21:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 12:21 [PATCH] Make it possible to call canonicalize_filename_mode from C++ James Youngman
2019-05-28 21:06 ` Bruno Haible [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1879324.D8i1emut2y@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=jay@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).