From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B55361F4B4 for ; Sat, 17 Apr 2021 15:17:56 +0000 (UTC) Received: from localhost ([::1]:36622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXmhn-00010J-JU for normalperson@yhbt.net; Sat, 17 Apr 2021 11:17:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXmhd-00010A-W8 for bug-gnulib@gnu.org; Sat, 17 Apr 2021 11:17:46 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.160]:25271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXmhb-0000gj-Ev for bug-gnulib@gnu.org; Sat, 17 Apr 2021 11:17:45 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1618672659; cv=none; d=strato.com; s=strato-dkim-0002; b=Fa/aBgbEnirhU9qHAFOoi0/gil8H1IoyRfN66mruHOTG7hoKJmPu6AmNHIGZpaCd02 zs4YnPiPMJecKxEYQFDfxAon83pZ1wsho+Hgd7XYIVVET03PUo4oGOZpNvRY2kfrCCmB Wk50fGVB+cn35s4LBvpYzV1MJnldF4OFRSgrFkgW589k7cejI77wC1M7gap9hjQHuGPD YknW+B6hrrmSjHdjDYJfbZxMTAVVTvouOe8PYQKVp2TKo7tEbx9+mmsuFEJH9Vxr/dGB dH6PP5sIveNtl4zxwuQriYHpgxHXF/yhjBXjMUn0e7ozCesMK0uk0xd/OLYm5cpzkdZq vFLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1618672659; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=cQmbNkYD4cR4HcKkb2Ip7v9sOOkcvjAcFy99dPuQxrk=; b=JCnIz42GeFAHqwEDswypmDNRQn0xo2ejc3P3ltZtPMfTxCU+ivOfo5MJP2VbXIIOso mFBH12qmGYDignsXgAX9n05oJqrhMA/GCUxF7sLId4siXhs9NDdL3FRQMxyhRtkbWAJW ZFvGNlWw40B+wVtWoa3r/Ri+fDACznF76pcekJNbMmb/yV321d6ooMikqVkakXAk+nCc i9sX2u52VvXJe7+o0svnmyruz/GgZjYQUVAZko7/F5AHHK8uhivUfuwTK5oIobzftRuL xL6UYEpJEDQXG9H7KmNzsEqm7kQKr0Rv1MOzred3Wr4FGkFKGn6qJuOlfIYdWsozB2H5 WVuQ== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1618672659; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=cQmbNkYD4cR4HcKkb2Ip7v9sOOkcvjAcFy99dPuQxrk=; b=H6jLSAIaqReCOFYENCyswO8qb4T08kgTrbkh4z+59MwM9nFgpf7ee/zq0eex7JPeOL +I+7BoTgmlDHUFB8gqPhOTD+JPrsbvpk7Tg0UK+WzqUCstc62qWkR2a9v9XRW/WcZ650 H2rmSDw9J1Q2LDRHDfxCXBwbsj36SPcpaJcYdzoJN3JdXzuM2aTIXfjYnl4dw2fyrNqM ltJOTtZbGt4Ky3AwbeuJWGcYC+hwwXXVX4kbMzGVhA7kVIiIjxYnc5QPuagsQ+wc7qhB dWe3Oteme2lodx4FvnrfZh0wYkaDQPovvKRsuD1KIrXGsqBTOulJrrBB+X7gxyZfUx17 n+5g== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOHqf3z5NW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.24.3 DYNA|AUTH) with ESMTPSA id N0a7e0x3HFHdB12 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sat, 17 Apr 2021 17:17:39 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: Interference between two installations of gnulib Date: Sat, 17 Apr 2021 17:17:38 +0200 Message-ID: <1716535.PRYyZtHhnx@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-206-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <43737965.862IWm2pC9@omega> References: <43737965.862IWm2pC9@omega> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.160; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Reuben Thomas Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" These patches caused a build failure in GNU libunistring: gcc -DHAVE_CONFIG_H -DEXEEXT=\"\" -I. -I../../../sources/libunistring/tests -I../lib -I.. -DIN_LIBUNISTRING_GNULIB_TESTS=1 -I. -I../../../sources/libunistring/tests -I.. -I../../../sources/libunistring/tests/.. -I../lib -I../../../sources/libunistring/tests/../lib -Wall -g -O2 -MT locale.o -MD -MP -MF $depbase.Tpo -c -o locale.o ../../../sources/libunistring/tests/locale.c &&\ mv -f $depbase.Tpo $depbase.Po In file included from ../../../sources/libunistring/tests/locale.c:22:0: ./stdio.h:830:5: error: #if with no expression ./stdio.h:846:5: error: #if with no expression ... The problem is that the macro gl_STDIO_H_REQUIRE_DEFAULTS must only be invoked, never AC_REQUIREd. Hence all gl_STDIO_MODULE_INDICATOR invocations must also only be invoked, never AC_REQUIREd. But gl_STDIO_H is automatically AC_REQUIREd, since it is defined through AC_DEFUN_ONCE. This patch fixes it. 2021-04-17 Bruno Haible stdio: Fix build error in some configurations (regression 2021-04-11). * m4/stdio_h.m4 (gl_STDIO_H): Move gl_STDIO_MODULE_INDICATOR and gl_MODULE_INDICATOR invocations from here... * modules/stdio (configure.ac): ... to here. diff --git a/m4/stdio_h.m4 b/m4/stdio_h.m4 index 6846ca6..d9820e4 100644 --- a/m4/stdio_h.m4 +++ b/m4/stdio_h.m4 @@ -1,4 +1,4 @@ -# stdio_h.m4 serial 54 +# stdio_h.m4 serial 55 dnl Copyright (C) 2007-2021 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -40,17 +40,6 @@ AC_DEFUN_ONCE([gl_STDIO_H], attribute "__gnu_printf__" instead of "__printf__"]) fi - dnl No need to create extra modules for these functions. Everyone who uses - dnl likely needs them. - gl_STDIO_MODULE_INDICATOR([fscanf]) - gl_MODULE_INDICATOR([fscanf]) - gl_STDIO_MODULE_INDICATOR([scanf]) - gl_MODULE_INDICATOR([scanf]) - gl_STDIO_MODULE_INDICATOR([fgetc]) - gl_STDIO_MODULE_INDICATOR([getc]) - gl_STDIO_MODULE_INDICATOR([getchar]) - gl_STDIO_MODULE_INDICATOR([fgets]) - gl_STDIO_MODULE_INDICATOR([fread]) dnl This ifdef is necessary to avoid an error "missing file lib/stdio-read.c" dnl "expected source file, required through AC_LIBSOURCES, not found". It is dnl also an optimization, to avoid performing a configure check whose result @@ -64,18 +53,6 @@ AC_DEFUN_ONCE([gl_STDIO_H], fi ]) - dnl No need to create extra modules for these functions. Everyone who uses - dnl likely needs them. - gl_STDIO_MODULE_INDICATOR([fprintf]) - gl_STDIO_MODULE_INDICATOR([printf]) - gl_STDIO_MODULE_INDICATOR([vfprintf]) - gl_STDIO_MODULE_INDICATOR([vprintf]) - gl_STDIO_MODULE_INDICATOR([fputc]) - gl_STDIO_MODULE_INDICATOR([putc]) - gl_STDIO_MODULE_INDICATOR([putchar]) - gl_STDIO_MODULE_INDICATOR([fputs]) - gl_STDIO_MODULE_INDICATOR([puts]) - gl_STDIO_MODULE_INDICATOR([fwrite]) dnl This ifdef is necessary to avoid an error "missing file lib/stdio-write.c" dnl "expected source file, required through AC_LIBSOURCES, not found". It is dnl also an optimization, to avoid performing a configure check whose result diff --git a/modules/stdio b/modules/stdio index 18c24d7..e13b689 100644 --- a/modules/stdio +++ b/modules/stdio @@ -19,6 +19,31 @@ configure.ac: gl_STDIO_H gl_STDIO_H_REQUIRE_DEFAULTS +dnl No need to create extra modules for these functions. Everyone who uses +dnl likely needs them. +gl_STDIO_MODULE_INDICATOR([fscanf]) +gl_MODULE_INDICATOR([fscanf]) +gl_STDIO_MODULE_INDICATOR([scanf]) +gl_MODULE_INDICATOR([scanf]) +gl_STDIO_MODULE_INDICATOR([fgetc]) +gl_STDIO_MODULE_INDICATOR([getc]) +gl_STDIO_MODULE_INDICATOR([getchar]) +gl_STDIO_MODULE_INDICATOR([fgets]) +gl_STDIO_MODULE_INDICATOR([fread]) + +dnl No need to create extra modules for these functions. Everyone who uses +dnl likely needs them. +gl_STDIO_MODULE_INDICATOR([fprintf]) +gl_STDIO_MODULE_INDICATOR([printf]) +gl_STDIO_MODULE_INDICATOR([vfprintf]) +gl_STDIO_MODULE_INDICATOR([vprintf]) +gl_STDIO_MODULE_INDICATOR([fputc]) +gl_STDIO_MODULE_INDICATOR([putc]) +gl_STDIO_MODULE_INDICATOR([putchar]) +gl_STDIO_MODULE_INDICATOR([fputs]) +gl_STDIO_MODULE_INDICATOR([puts]) +gl_STDIO_MODULE_INDICATOR([fwrite]) + Makefile.am: BUILT_SOURCES += stdio.h