From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: regex: avoid memory leak
Date: Wed, 24 Jul 2019 05:03:08 +0200 [thread overview]
Message-ID: <15819003.QUfdhuhlib@omega> (raw)
Can someone please review this?
2019-07-23 Bruno Haible <bruno@clisp.org>
regex: Avoid memory leak.
Reported by Coverity (CID 1484201).
* lib/regex_internal.c (create_cd_newstate): Free newstate if we cannot
allocate newstate->entrance_nodes.
diff --git a/lib/regex_internal.c b/lib/regex_internal.c
index 9004ce8..02b2e09 100644
--- a/lib/regex_internal.c
+++ b/lib/regex_internal.c
@@ -1724,7 +1724,10 @@ create_cd_newstate (const re_dfa_t *dfa, const re_node_set *nodes,
}
if (re_node_set_init_copy (newstate->entrance_nodes, nodes)
!= REG_NOERROR)
- return NULL;
+ {
+ free_state (newstate);
+ return NULL;
+ }
nctx_nodes = 0;
newstate->has_constraint = 1;
}
next reply other threads:[~2019-07-24 3:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 3:03 Bruno Haible [this message]
2019-07-26 7:03 ` regex: avoid memory leak Paul Eggert
2019-07-28 15:31 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15819003.QUfdhuhlib@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).