From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9870A1F461 for ; Tue, 2 Jul 2019 02:42:12 +0000 (UTC) Received: from localhost ([::1]:47458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi8kE-0006sA-Rf for normalperson@yhbt.net; Mon, 01 Jul 2019 22:42:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34466) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi4sL-0005m1-C7 for bug-gnulib@gnu.org; Mon, 01 Jul 2019 18:34:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hi4sE-0002jl-C7 for bug-gnulib@gnu.org; Mon, 01 Jul 2019 18:34:14 -0400 Received: from mout.gmx.net ([212.227.17.22]:41549) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hi4s7-0000ht-15 for bug-gnulib@gnu.org; Mon, 01 Jul 2019 18:34:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1562020312; bh=C6WyXya9WukzkWlg3OYT9Rl5LlfRHvMJVXTeryTDAbw=; h=X-UI-Sender-Class:Subject:From:To:Cc:Date:In-Reply-To:References; b=XdZU6oy7Wf09YxEPBB8sr3L9ZBDzcaqWC5MFcDJtlOM1jMo15VjzuAaLG1/UbiH4Z Sns1auoloQeU2G6oVlQH+b3fJXqzAWcftiyaE0PDxHXdCerEa0lrPYRO3/2j0m61Qd 05IXfAhGeTYtBnczZi6aEW23Qj80Meu7f17YfX/4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from w01.local ([88.70.20.132]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvbBu-1iZQFv2T1a-00sb2s; Mon, 01 Jul 2019 20:16:45 +0200 Message-ID: <1562005002.1925.8.camel@gmx.de> Subject: Patch: Fix warning for timeval in poll.c on mingw-w64 for x86_64 From: Hannes =?ISO-8859-1?Q?M=FCller?= To: Bruno Haible Date: Mon, 01 Jul 2019 20:16:42 +0200 In-Reply-To: <5622404.O4zSVXqarr@omega> References: <1561791270.1634.5.camel@gmx.de> <67909157.2iZzdWHPA0@omega> <1561833176.1274.10.camel@gmx.de> <5622404.O4zSVXqarr@omega> Content-Type: multipart/mixed; boundary="=-UC2mlEiqork/LwV52jTR" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 X-Provags-ID: V03:K1:j2nq0P6hkKACYiupWa7wGoQATnEnad15cbOLBx1Ted2Thq+QDgc axPIKEDzf1fBG+ugYsobzBQoJMYoxyurM+aSOhyRQYDGJCSEZIRBmiOX82Cr1Iqpesbydpn H2cnQMPWLjpvnqubV6alge9S0Vhip9wY6OCcpbL6YvlGfs12COkkwkYpG+oKbtVWSXriQwc evPil4x1fjfufSSnv/pGg== X-UI-Out-Filterresults: notjunk:1;V03:K0:bqa4roBwXgI=:OCgdgGL9y09OrBTBdMlPet eUU+x8BH3quOLB08KJ6wIL1N8wLH2EHDtZaDRud7MDL+PdTPAi/K2shIe27QbbwnYKdwC7e6t UwGfucdkHIZ+Y8pG+81T4qOdk5zw9FK8vzxsQWuK81hLQ2Oy8NPU8mBnuHeCMFsdwma86ttmi KfC4qL9fcl6FOoQpbM6GMVfe76wHQL+8BFiHQSktgsLIYqwbyCNkj/bS8/OxivCbGohBmkKtR kGtv8diXEPV9HqmXZvPHbUpDOhypa6NRaZDPixDFBFVrn+cQkHnpwLaxh+SnzTtpLxIacP+H3 kLNtIBlbPht+Ar+M0oemdkbfyPGHeCgDWoMzvwKsnLrCQ93x1JjqJn+swR6KMJI6Ud5E8OnL+ ZVNdQkd32/lFdcMcBO4SOWK6NjQHTH0SOYqvV+aBg7o2YRcaDnpR4B0sYFAdV7g7ta+PhMy7l ftqbhYTpS66cjlZkVxUg1eT+PDWM0SkLi4TKXCMGuBa8jpm9PWumeuNEe5dzbBoqPp1UIaDp+ OQiEJYpv4LhrADDatLTq0miM3j1WFYNykk4tsmn7ywZhV2LWEU85OcZqwOO0nYziXtMkP01oI xbaSYb/qhQwM2CpwnIntiIsteJtuWndcu4LeIJ6Ev+Tab8g7AAa115I/MW+pRD5tVlA7TyTdI K7TVQyoI8ZHmJKic2B1qWe+lRE7R2sh8aS1n8/n1yYmHArcPtSfUN7cDYDicYNdVddAdrLDQX HGg3d8Yr3nK+aLzvcvB1PHiCJtRh3rUG82oeIOEK5G3yLjuKUe9jXyEgV4DoJ/s2PC9LlhzTc hNnv73jclhhxCN+gwLORL9Zln1z4hYxcoiT9HCcZyDQg3th33xSXhwvwqRq+BQie4UQsKGhp8 cG88JoH58fcGmQmgkbSSUNO68LBtMWLluLNwi9svUMt2/swU/fvD6DZ0sjscMT9RclHibUmRW SIr88L3SQSXE9F/A5n8e4YtV+zdiTk1ATYTckTjdrVykFgw7pfB3H6qoF54K0qpdKm1YHf0Jq TBz8RkKPcoc+bblmiMz21JrkT92D5H7buoI649JnDsz7mjrWc6BR/Jr050zOv3VJuhmdl/xl3 2Lnmv82d1rpErY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" --=-UC2mlEiqork/LwV52jTR Content-Type: multipart/alternative; boundary="=-8x4eRvMpGjw5RR/EeUiV" --=-8x4eRvMpGjw5RR/EeUiV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 SGkgQnJ1bm8sDQoNClRoYW5rcyBmb3IgcG9sbCB0aGUgZml4ZXMuwqANCkkgd291bGQgbGlrZSB0 byBwcm9wb3NlIGF0dGFjaGVkIHBhdGNoIHRvIGZpeCBvbiBtaW5ndy13NjQgZm9yIHg4Nl82NA0K c3RpbGwgcHJlc2VudCBwcm9ibGVtOg0KDQoNCnBvbGwuYzogSW4gZnVuY3Rpb24gJ3BvbGwnOg0K cG9sbC5jOjUyNjozOTogd2FybmluZzogcGFzc2luZyBhcmd1bWVudCA1IG9mICdzZWxlY3QnIGZy b20NCmluY29tcGF0aWJsZSBwb2ludGVyIHR5cGUgWy1XaW5jb21wYXRpYmxlLXBvaW50ZXItdHlw ZXNdDQrCoCA1MjYgfMKgwqDCoGlmIChzZWxlY3QgKDAsICZyZmRzLCAmd2ZkcywgJnhmZHMsICZ0 djApID4gMCkNCsKgwqDCoMKgwqDCoHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBefn5+DQrCoMKgwqDC oMKgwqB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfA0KwqDCoMKgwqDCoMKgfMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoHN0cnVjdCBycGxfdGltZXZhbCAqDQpJbiBmaWxlIGluY2x1ZGVkIGZyb20gLi9wb2xs Lmg6NDEsDQrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnJvbSBwb2xsLmM6MzI6 DQpDOi9Vc2Vycy9obS9Eb2N1bWVudHMvbXN5czMyL21pbmd3NjQveDg2XzY0LXc2NC0NCm1pbmd3 MzIvaW5jbHVkZS93aW5zb2NrMi5oOjk5NToxMTY6IG5vdGU6IGV4cGVjdGVkICdQVElNRVZBTCcg e2FrYQ0KJ3N0cnVjdCB0aW1ldmFsICogY29uc3QnfSBidXQgYXJndW1lbnQgaXMgb2YgdHlwZSAn c3RydWN0IHJwbF90aW1ldmFsDQoqJw0KwqAgOTk1IHzCoMKgwqBXSU5TT0NLX0FQSV9MSU5LQUdF IGludCBXU0FBUEkgc2VsZWN0KGludCBuZmRzLGZkX3NldA0KKnJlYWRmZHMsZmRfc2V0ICp3cml0 ZWZkcyxmZF9zZXQgKmV4Y2VwdGZkcyxjb25zdCBQVElNRVZBTCB0aW1lb3V0KTsNCsKgwqDCoMKg wqDCoHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoA0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB+fn5+fn5+fn5+fn5+fn5efn5+ fn5+DQpwb2xsLmM6NTYyOjM3OiB3YXJuaW5nOiBwYXNzaW5nIGFyZ3VtZW50IDUgb2YgJ3NlbGVj dCcgZnJvbQ0KaW5jb21wYXRpYmxlIHBvaW50ZXIgdHlwZSBbLVdpbmNvbXBhdGlibGUtcG9pbnRl ci10eXBlc10NCsKgIDU2MiB8wqDCoMKgwqDCoHNlbGVjdCAoMCwgJnJmZHMsICZ3ZmRzLCAmeGZk cywgJnR2MCk7DQrCoMKgwqDCoMKgwqB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBefn5+DQrCoMKgwqDCoMKg wqB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqB8DQrCoMKgwqDCoMKgwqB8wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBzdHJ1 Y3QgcnBsX3RpbWV2YWwgKg0KSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vcG9sbC5oOjQxLA0KwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGZyb20gcG9sbC5jOjMyOg0KQzovVXNlcnMv aG0vRG9jdW1lbnRzL21zeXMzMi9taW5ndzY0L3g4Nl82NC13NjQtDQptaW5ndzMyL2luY2x1ZGUv d2luc29jazIuaDo5OTU6MTE2OiBub3RlOiBleHBlY3RlZCAnUFRJTUVWQUwnIHtha2ENCidzdHJ1 Y3QgdGltZXZhbCAqIGNvbnN0J30gYnV0IGFyZ3VtZW50IGlzIG9mIHR5cGUgJ3N0cnVjdCBycGxf dGltZXZhbA0KKicNCsKgIDk5NSB8wqDCoMKgV0lOU09DS19BUElfTElOS0FHRSBpbnQgV1NBQVBJ IHNlbGVjdChpbnQgbmZkcyxmZF9zZXQNCipyZWFkZmRzLGZkX3NldCAqd3JpdGVmZHMsZmRfc2V0 ICpleGNlcHRmZHMsY29uc3QgUFRJTUVWQUwgdGltZW91dCk7DQrCoMKgwqDCoMKgwqB8wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqANCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfn5+fn5+fn5+fn5+fn5+Xn5+fn5+DQoNCg0KDQpJ dCB0dXJucyBvdXTCoGluIHN5c190aW1lLmluLmg6DQppNjg2OsKgwqDCoEBSRVBMQUNFX1NUUlVD VF9USU1FVkFMQD0wDQp4ODZfNjQ6IEBSRVBMQUNFX1NUUlVDVF9USU1FVkFMQD0xDQoNCg0KY2F1 c2luZyBwb2xsLmMgbGluZSA0NDggb24geDg2XzY0IHRvIGJlY29tZQ0Kc3RhdGljIHN0cnVjdCBy cGxfdGltZXZhbCB0djA7DQoNCg0KQnV0IHBvbGwuYyBpbiBsaW5lIDkwIHN0YXRlczoNCi8qIEhl cmUgd2UgbmVlZCB0aGUgc2VsZWN0KCkgZnVuY3Rpb24gZnJvbSBXaW5kb3dzLCBiZWNhdXNlIHdl IHBhc3MgYml0DQptYXNrc8KgDQrCoMKgwqBvZiBTT0NLRVRzLCBub3QgYml0IG1hc2tzIG9mIEZE cy7CoMKgKi8NCg0KU28gd2UgbmVlZCBhbHNvIHRoZSBvcmlnaW5hbCB0aW1ldmFsIGRlZmluaXRv biBmcm9tIFdpbmRvd3MgYXQgbGVhc3QNCmZvciB4ODZfNjQuDQoNClRoYW5rcyBmb3IgcmV2aWV3 aW5nIHRoZSBwYXRjaC4NCg0KQmVzdCByZWdhcmRzDQpIYW5uZXMNCg== --=-8x4eRvMpGjw5RR/EeUiV Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi Bruno,

=
Thanks for poll the fixes. 
I would like to propose att= ached patch to fix on mingw-w64 for x86_64 still present problem:

poll.c: In function 'poll':
poll.c:526:39: warning: passing argument 5 of 'se= lect' from incompatible pointer type [-Wincompatible-pointer-types]<= /div>
  526 |   = ;if (select (0, &rfds, &wfds, &xfds, &tv0) > 0)
     =  |           &n= bsp;            = ;            &n= bsp;  ^~~~
&= nbsp;     |      &nb= sp;            =             &nb= sp;       |
      |  =             &nb= sp;            =             str= uct rpl_timeval *
In f= ile included from ./poll.h:41,
           =       from poll.c:32:
C:/Users/hm/Documents/msys32/mingw64/x86_64-w= 64-mingw32/include/winsock2.h:995:116: note: expected 'PTIMEVAL' {aka 'stru= ct timeval * const'} but argument is of type 'struct rpl_timeval *'<= /div>
  995 |   = ;WINSOCK_API_LINKAGE int WSAAPI select(int nfds,fd_set *readfds,fd_set *wri= tefds,fd_set *exceptfds,const PTIMEVAL timeout);
      |  = ;            &n= bsp;            = ;            &n= bsp;            = ;            &n= bsp;            = ;            &n= bsp;           ~~~~~= ~~~~~~~~~~^~~~~~~
poll= .c:562:37: warning: passing argument 5 of 'select' from incompatible pointe= r type [-Wincompatible-pointer-types]
  562 |     select (0, &r= fds, &wfds, &xfds, &tv0);
      |   &nbs= p;            &= nbsp;           &nbs= p;        ^~~~
      | = ;            &n= bsp;            = ;           |=
    &nbs= p; |           =             &nb= sp;            =  struct rpl_timeval *
In file included from ./poll.h:41,
         &= nbsp;       from poll.c:32:
=
C:/Users/hm/Documents/msys32/mingw= 64/x86_64-w64-mingw32/include/winsock2.h:995:116: note: expected 'PTIMEVAL'= {aka 'struct timeval * const'} but argument is of type 'struct rpl_timeval= *'
  995 | =   WINSOCK_API_LINKAGE int WSAAPI select(int nfds,fd_set *readfds,= fd_set *writefds,fd_set *exceptfds,const PTIMEVAL timeout);
      |=             &nb= sp;            =             &nb= sp;            =             &nb= sp;            =             &nb= sp;            =  ~~~~~~~~~~~~~~~^~~~~~

It turns out in sys_time.in.h:
i686:   @RE= PLACE_STRUCT_TIMEVAL@=3D0
x86_64: @REPLACE_STRUCT_TIMEVAL@=3D1

causing poll.c line 448 on x86_64 to become
<= font face=3D"monospace" size=3D"3">static struct rpl_timeval tv0;

But poll.c in line 90 states:
/* Here we need the select() function from Window= s, because we pass bit masks 
of SOCKETs, not bit masks of FDs.  */

So we need also the original timeval definiton from Wi= ndows at least for x86_64.

Thanks for reviewing th= e patch.

Best regards
Hannes
--=-8x4eRvMpGjw5RR/EeUiV-- --=-UC2mlEiqork/LwV52jTR Content-Disposition: attachment; filename*0=Fix_warning_for_timeval_in_poll_c_on_mingw_w64_for_x86_64.pat; filename*1=ch Content-Type: text/x-patch; name="Fix_warning_for_timeval_in_poll_c_on_mingw_w64_for_x86_64.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzYTQ2ZWM1NTdmNzJkNGM0NmFkYmE4ZThiMzlhNjM0NGJiOTExNTcwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SGFubmVzPTIwTT1DMz1CQ2xsZXI/PSA8aC5j LmYubXVlbGxlckBnbXguZGU+CkRhdGU6IE1vbiwgMSBKdWwgMjAxOSAxNjo1OTo0NSArMDIwMApT dWJqZWN0OiBbUEFUQ0hdIEZpeCB3YXJuaW5nIGZvciB0aW1ldmFsIGluIHBvbGwuYyBvbiBtaW5n dy13NjQgZm9yIHg4Nl82NAoKKiBsaWIvcG9sbC5jOiBjYWxsIHdpbmRvd3MgbmF0aXZlIHNlbGVj dCgpIHdpdGggd2luZG93cyBuYXRpdmUgdGltZXZhbAotLS0KIGxpYi9wb2xsLmMgfCA0ICsrKysK IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saWIvcG9sbC5j IGIvbGliL3BvbGwuYwppbmRleCA1ZDkxNTBjMTMuLjMzMDE0NDk1MCAxMDA2NDQKLS0tIGEvbGli L3BvbGwuYworKysgYi9saWIvcG9sbC5jCkBAIC05MSw2ICs5MSwxMCBAQAogICAgb2YgU09DS0VU cywgbm90IGJpdCBtYXNrcyBvZiBGRHMuICAqLwogIyB1bmRlZiBzZWxlY3QKIAorLyogSGVyZSB3 ZSBuZWVkIHRpbWV2YWwgZnJvbSBXaW5kb3dzIHNpbmNlIHRoaXMgaXMgd2hhdCBzZWxlY3QoKSBm dW5jdGlvbgorICAgZnJvbSBXaW5kb3dzIHJlcXVpcmVzICovCisjIHVuZGVmIHRpbWV2YWwKKwog LyogQXZvaWQgd2FybmluZ3MgZnJvbSBnY2MgLVdjYXN0LWZ1bmN0aW9uLXR5cGUuICAqLwogIyBk ZWZpbmUgR2V0UHJvY0FkZHJlc3MgXAogICAgKHZvaWQgKikgR2V0UHJvY0FkZHJlc3MKLS0gCjIu MjIuMAoK --=-UC2mlEiqork/LwV52jTR--