From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B3FAC1F4B4 for ; Tue, 22 Sep 2020 15:04:53 +0000 (UTC) Received: from localhost ([::1]:35550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKjqe-0003RP-1N for normalperson@yhbt.net; Tue, 22 Sep 2020 11:04:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKjqM-0003HC-0a for bug-gnulib@gnu.org; Tue, 22 Sep 2020 11:04:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51426) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKjqH-00040k-Rx; Tue, 22 Sep 2020 11:04:32 -0400 Received: from c-71-198-222-86.hsd1.ca.comcast.net ([71.198.222.86]:47556 helo=[172.16.16.102]) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1kKjqH-0000HP-GH; Tue, 22 Sep 2020 11:04:29 -0400 Subject: Re: gc-pbkdf2-sha1 is deprecated From: Bruce Korb To: Bruno Haible , bug-gnulib@gnu.org References: <4725cba4-3dc2-314a-0e1d-fb48c1a51540@gnu.org> <61d0906e-aa38-8c92-8d9f-ece85a8dccbf@gnu.org> <1671692.6njsL75u0N@omega> <15f388d6-fd18-178d-e58c-6199e950086c@gnu.org> Message-ID: <133410b7-2cd7-9a24-71e5-e9c6a8e72b14@gnu.org> Date: Tue, 22 Sep 2020 08:04:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <15f388d6-fd18-178d-e58c-6199e950086c@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Bruno, et al., The failing difference isn't whether or not I use gc_pbkdf2_hmac vs. gc_pbkdf2_sha1, the failing difference is whether or not I specify the crypto/gc-pbkdf2-sha1 module vs. the crypto/gc-pbkdf2 module. The former works, the latter does not, with the rest of my project entirely unchanged. Feel free to test it, assuming you have the autogen suite for bootstrapping: [remote "origin"]         url = bkorb@git.savannah.gnu.org:/srv/git/gnu-pw-mgr.git Without specifying the "-sha1" module, the make check fails with the pbkdf2 function returning 5. Here's the patch that causes the project to fail: diff --git a/bootstrap.conf b/bootstrap.conf index b0e397a..7703c6f 100755 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -90,7 +90,7 @@ initialize() {      gnulib_modules='          base64              \          close               \ -        crypto/gc-pbkdf2-sha1 \ +        crypto/gc-pbkdf2      \          crypto/gc-random    \          crypto/sha256       \          ctype               \ and it yields this error message: +++T=gpw-53> /u/bkorb/tools/gnu-pw-mgr-bld/src/gnu-pw-mgr --config-file=/tmp/gpw-3tsXGB/.local/gnupwmgr.cfg --rehash=1 -i test-tag who gnu-pw-mgr fatal error: gc_pbkdf2_sha1 returned error code 5 On 9/21/20 3:49 PM, Bruce Korb wrote: >> It may go away, because the module crypto/gc-pbkdf2 contains more >> generic API to do the same thing: gc_pbkdf2_hmac with first argument >> GC_SHA1. >> >> Bruno >> >> > >