From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DE14F1F4B4 for ; Tue, 5 Jan 2021 13:07:35 +0000 (UTC) Received: from localhost ([::1]:39208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwm3i-0000Xw-CP for normalperson@yhbt.net; Tue, 05 Jan 2021 08:07:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwm3Y-0000XY-Dd for bug-gnulib@gnu.org; Tue, 05 Jan 2021 08:07:24 -0500 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:39127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwm3U-0003OM-5v for bug-gnulib@gnu.org; Tue, 05 Jan 2021 08:07:24 -0500 Received: by mail-qk1-x72f.google.com with SMTP id p14so26321644qke.6 for ; Tue, 05 Jan 2021 05:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FvWdqpAKG9WK3Gqwnic14c4wUxi4sALahQ1dGMvBEAA=; b=KTlJU2GVg7eH0OnrCrdH1i6/+mfVX6XsKzI+KM0yR+cmx5AhmRf173S6nqNjDOaEXZ MazM4Zp2O+vfiVk0p3NZq7y0ctHQT1GZ0vxNC+YJhprOANJinY4je6+TT73Zdz5a8UJD 7P4J7WVWHvlp8w4MIeFVfKailQRi0QwUYNVuFPf+E+PyvyXgUj+B6q1NqkIuD4HsAl1Z 2OiTT/5I8ENkTPpxVSbwHutU/9jhjMzjpdTlq8nOl/rKouN4QCeXvwge1YsORVj0xgpq lRG5nhZ/U4Q/p3+QRdBT9LfF4P5Fgf9UDcVlsjGa+5EW+33F7Ra6QHzp5z7/FcxT+P5p ytuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=FvWdqpAKG9WK3Gqwnic14c4wUxi4sALahQ1dGMvBEAA=; b=ibJKBXCun2PREl0Q7Zf8BV8v0bwZGSXFMEnadZS5IDNVyIY50Xdaer8EQgKT4btKRI RjMzhAMXkCvRYZHJB8oD6BhCs918+IKdxlg7a8MtllwZ48N/QwbiHJyNCX21m19msJma H8COe1fR3g6IOfG8KYMWLe4Ai+YAjky0RZNxhcC0lvp0eWQL7K3UrStJmPEVWbSBjX5P eHjdOu7yWWroe520Z4aaaZREJ36grWK78wY4P9ua8OQklplVv4oBD+yYv3DTgyXmYfBm 4MLtkQSC8Fj0RHTymaKYM3aNO+LT8Rw9ZmGlL/7CDAzCyI5iZ96Gnt+EsVhhFA1sS/Pc MaXQ== X-Gm-Message-State: AOAM532au64xa1VIvfrt2mI6IX+Td3g+V0t831rAzBPPktw2ZM1wklLl CtZ5ozU4x8Vy92IH59/l22T4fWVWgXHqVw== X-Google-Smtp-Source: ABdhPJxZovovjCw1PFLU1yS+3fpgVJ1bVhATWBqit+FyDw/JdLcG9EMAPEYCuwWTw4R+wjYwpMHgkQ== X-Received: by 2002:a37:d2c7:: with SMTP id f190mr43545437qkj.95.1609852036753; Tue, 05 Jan 2021 05:07:16 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id d2sm38026096qtp.71.2021.01.05.05.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 05:07:16 -0800 (PST) To: Florian Weimer , Adhemerval Zanella via Libc-alpha , Paul Eggert References: <20210104202528.1228255-1-adhemerval.zanella@linaro.org> <87y2h8h23r.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 1/2] posix: User scratch_buffer on fnmatch Message-ID: <115de832-1949-4402-92af-a055653e9ce9@linaro.org> Date: Tue, 5 Jan 2021 10:07:12 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87y2h8h23r.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::72f; envelope-from=adhemerval.zanella@linaro.org; helo=mail-qk1-x72f.google.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 04/01/2021 17:35, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> It removes the alloca usage on the string convertion to wide characters >> before calling the internal function. > > We have a downstream-only patch to fall back the single byte handling in > case of multibyte decoding failure. Basically it's a quick hack to fix > this bug: > > > > Is this something we should upstream? Or rework fnmatch so that * is > matched properly against arbitrary bytes? It seems that gnulib has added the proposed fix with aed23714d60d91b2abc74be33635c32ddc5132b5 (done in 2005) and just recently with a glibc merge with 67306f600fe6a3bcf3fbb6d8bf4b8953b74a8fb7 (done in 2020 to sync back glibc changes) it has fallback to old semantic to return -1 on in case of failure. I am not sure if gnulib was intentional or an overlook. But I am slight worried about the issues raised by Rich in comment #4, where fnmatch would match wrong patterns that happen to have invalid multibyte sequence. Maybe gnulib guys can gives us some insight here about the realword and if the 67306f600fe6a3 was intentional or not. I have started to check the feasibility or making the Rich suggestions at comment #7, to make fnmatch not go in the temporary buffer and call mbrtowc. It should be feasible, however it would require more extensive change in the algorithm and some work to optimize for MB_CUR_MAX == 1 (where mbrtowc should not be necessary).