From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 033D31F4B4 for ; Wed, 20 Jan 2021 11:27:35 +0000 (UTC) Received: from localhost ([::1]:40516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2Be9-0007sF-Ps for normalperson@yhbt.net; Wed, 20 Jan 2021 06:27:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2Be5-0007s7-Ve for bug-gnulib@gnu.org; Wed, 20 Jan 2021 06:27:29 -0500 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:42399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2Be4-0004RR-0b for bug-gnulib@gnu.org; Wed, 20 Jan 2021 06:27:29 -0500 Received: by mail-qt1-x830.google.com with SMTP id e15so15957115qte.9 for ; Wed, 20 Jan 2021 03:27:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m9QLYebFSydbs/QBUk7k8RqaDdfOsXi84Zh5z1cWh2U=; b=huLKQWkQHZQOON6J4R79jUopFRq8z99/s2RaBOUTkSgIx8QznXGGm+rurwqC+cchQ3 LO+5DTz4aSn7K+z+d6PQJZ+okwy31kNUmhkDoYjR6jeBUZL8iqivR3pwijcrFn+p38Bt aznAoj8VPZ+egnzJz1rc79xZ7yxNDQZ/ttGnyYRk9GHxqU24Mh3tlfMANk0JTVq2I3JK 3NsDXCQ4/cAwZOn35BHe6P6pVLHjZL7+ws71orifkW2RWKBx+j4M+64ii3O5mUbU/Om6 3BdmYjCNMf/q4hOJnueNEB0cH6oYhd3ELpLxr3YrhbocGfxmoi5UjJMYvksrEEZEozeV po+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=m9QLYebFSydbs/QBUk7k8RqaDdfOsXi84Zh5z1cWh2U=; b=Fb09Z3KRraei0pJdbGDEMNKRTmglB5vsao97LB4vCGmWPlhRG0yOiyDvfwh6y7Xx0L jJYErNNWPtz99N4OO3rKd1VU83T10tAMUlMhvKKs4m9XCE8F4tP8i+EVbhI4UmTpGtpx QVu9yj4c2cSX116eqDKS4bhDx63yM9tEGpz7YFhpGLIK/XdC5w74fepmpTn1EhDLVNoX +kiMlhOUbsNMZsiHl7qO+wTja3wZsnNSZJofNNp9pzp7z+sfRVWpSUdkRE5BRloKCt4n rVVufOTqq4PyeXnkUVOMCm0h+W+jeuHyMIyZYZGsjNYa+ZT2LfguTl1CjDb8G0o52KHF CzyQ== X-Gm-Message-State: AOAM533dZZUI5r3E6tnCZB4PgY0qPA3QOFBT2ey5gCGX56iuchS7N++A MstwUMsQ2tXmR0COND2cZdLTpBP1xKwADg== X-Google-Smtp-Source: ABdhPJy0kh0Nc8aq1M103U8AEy1A1uPJE+ruhTPMcYDTVXj82jqr8jbBZPEJ5ZSqka1EZ0jW+gA5Fg== X-Received: by 2002:ac8:7ca:: with SMTP id m10mr474261qth.231.1611142046599; Wed, 20 Jan 2021 03:27:26 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id u5sm1103191qka.86.2021.01.20.03.27.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 03:27:25 -0800 (PST) Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib To: Paul Eggert , Bruno Haible References: <20201230201507.2755086-1-adhemerval.zanella@linaro.org> <909632B5-141E-4567-8E62-3DAF91CB8E33@arm.com> <74ac97a1-2186-1937-4595-ab7409d663d0@linaro.org> <2108975.lN1YhbmyTB@omega> <05f5e913-f1d1-b2f9-beb7-f226588733c0@cs.ucla.edu> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <10cb3123-40a4-931f-c658-99382367db6b@linaro.org> Date: Wed, 20 Jan 2021 08:27:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <05f5e913-f1d1-b2f9-beb7-f226588733c0@cs.ucla.edu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::830; envelope-from=adhemerval.zanella@linaro.org; helo=mail-qt1-x830.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org, "libc-alpha@sourceware.org" , Vaseeharan Vinayagamoorthy Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 19/01/2021 23:55, Paul Eggert wrote: > On 1/19/21 7:43 AM, Bruno Haible wrote: >> Adhemerval Zanella wrote: >>> -# if (__GNUC__ >= 7) || (__clang_major__ >= 10) >>> +# if (__GNUC__ >= 7) || (defined __clang_major__ &&__clang_major__ >= 10) >> I would write it as: >> >> +# if (__GNUC__ >= 7) || (defined __clang__ && __clang_major__ >= 10) > > This line should be used only if _LIBC is defined, so we can simplify it to just "#if __GNUC__ >= 7" and thus not worry about Clang. > > I see that Gnulib wasn't consistent about this, so I installed the attached patch to Gnulib to fix the issue here and elsewhere. The idea is that the Gnulib regex_internal.h can be copied back to glibc, and that the other uses in Gnulib should be similar. Thanks, I will check with a bootstrap build and sync regex_internal.h with glibc. > > On 1/19/21 6:43 AM, Adhemerval Zanella wrote: > >> Paul, this seemed to a common pattern scatter on multiple file in gnulib. >> Wouldn't be better to consolidate it on cdefs.h? > > We could append something like the following to cdefs.h, and switch to __attribute_fallthrough__ for modules shared between the two systems. Is that something you'd like to pursue? (We should also sync Gnulib cdefs.h back to glibc of course.) > > #if defined __STDC_VERSION__ && 201710L < __STDC_VERSION__ > # define __attribute_fallthrough__ [[__fallthrough__]] > #elif __GNUC_PREREQ (7, 0) || __glibc_has_attribute (__fallthrough__) > # define __attribute_fallthrough__ __attribute__ ((__fallthrough__)) > #else > # define __attribute_fallthrough__ ((void) 0) > #endif Yes, for 2.34 I will send some patches to sync the remaining gnulib files and document from our part the shared files.