bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Collin Funk <collin.funk1@gmail.com>
Subject: Re: [PATCH] gnulib-tool.py: Fix function call on incorrect object.
Date: Mon, 19 Feb 2024 03:17:26 +0100	[thread overview]
Message-ID: <10243767.qOBuL9xsDt@nimes> (raw)
In-Reply-To: <678e8e4f-4609-4a61-8c56-231c1e7f7d97@gmail.com>

Hi Collin,

> GNU m4 gave the following error:
> 
> bootstrap: running: gnulib/gnulib-tool.py --no-changelog --no-libtool --symlink --update
> Traceback (most recent call last):
>   File "/home/collin/.local/src/m4/gnulib/gnulib-tool.py", line 1171, in <module>
>     main()
>   File "/home/collin/.local/src/m4/gnulib/gnulib-tool.py", line 886, in main
>     importer = classes.GLImport(config, mode)
>                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/home/collin/.local/src/m4/gnulib/pygnulib/GLImport.py", line 243, in __init__
>     if self.checkInclTestCategory(TESTS['tests']) and self.config['conddeps']:
>        ^^^^^^^^^^^^^^^^^^^^^^^^^^
> AttributeError: 'GLImport' object has no attribute 'checkInclTestCategory'
> 
> I assume this was just caused by a small coding typo (if that is a
> thing). This patch should fix it.

Thanks! Applied.

> What is the status of the Python gnulib tool? I'm not sure how far
> behind it is compared to the shell script but it seems like it would
> be much faster. I would say more maintainable but I might just be bad
> at writing shell scripts. :)

Yes, it's the hope that it will be faster that is the main motivation
behind the Python rewrite.

The status: It's about 2/3 complete. 4 months of work have gone into it,
and 2 months of work still remaining. (That's my estimation, based on
two weeks of work that I put in, in 2022.)
65% of the .py code has been verified to be in sync with the bash code;
35% still to go. And then, the changes from the gnulib-tool.py.TODO list
need to me implemented on the Python side.
Then would come a phase of public testing...

Bruno





  reply	other threads:[~2024-02-19  2:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19  1:24 [PATCH] gnulib-tool.py: Fix function call on incorrect object Collin Funk
2024-02-19  2:17 ` Bruno Haible [this message]
2024-02-19  8:59   ` Simon Josefsson via Gnulib discussion list
2024-02-19 10:38     ` gnulib-tool caching Bruno Haible
2024-02-19 12:55       ` Simon Josefsson via Gnulib discussion list
2024-02-19 21:50         ` Bruno Haible
2024-02-19 22:24           ` Sam James
2024-02-19 23:11             ` Bruno Haible
2024-02-19 23:17               ` Sam James
2024-02-19 18:37   ` [PATCH] gnulib-tool.py: Fix function call on incorrect object Collin Funk
2024-02-19 21:36     ` Bruno Haible
2024-02-19 22:42       ` Collin Funk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10243767.qOBuL9xsDt@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=collin.funk1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).