From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5E3391F463 for ; Wed, 18 Dec 2019 01:45:11 +0000 (UTC) Received: from localhost ([::1]:48220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihOOj-0001xC-Nm for normalperson@yhbt.net; Tue, 17 Dec 2019 20:45:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37356) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihOOf-0001x2-Eq for bug-gnulib@gnu.org; Tue, 17 Dec 2019 20:45:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihOOd-00057U-QB for bug-gnulib@gnu.org; Tue, 17 Dec 2019 20:45:04 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41474) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihOOd-00055R-KY for bug-gnulib@gnu.org; Tue, 17 Dec 2019 20:45:03 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EC32B16016A; Tue, 17 Dec 2019 17:45:01 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Z65DMnW7mCj5; Tue, 17 Dec 2019 17:45:01 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5071B160179; Tue, 17 Dec 2019 17:45:01 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id v0bMHefyrbaj; Tue, 17 Dec 2019 17:45:01 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 136AF16016A; Tue, 17 Dec 2019 17:45:01 -0800 (PST) Subject: Re: hard-locale: make multithread-safe To: Bruno Haible References: <175192568.e2XXTFFdkW@omega> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <09a43701-a998-5c26-ea9e-51c8c3446084@cs.ucla.edu> Date: Tue, 17 Dec 2019 17:45:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <175192568.e2XXTFFdkW@omega> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Thanks, this change looks fine to me. I do have a qualm in that coreutils (and I assume others) interpret !hard_locale (LC_COLLATE) as meaning that the locale is unibyte and uses native byte comparison. As I recall on some platforms (macOS maybe?), the C locale uses UTF-8 so this interpretation isn't correct. This qualm is present both before and after the change, though. Perhaps the problem should be documented, but that could be the subject of a later patch.