From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 41AC71F63E for ; Sat, 28 Jan 2023 19:06:26 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=cs.ucla.edu header.i=@cs.ucla.edu header.a=rsa-sha256 header.s=78364E5A-2AF3-11ED-87FA-8298ECA2D365 header.b=Q6lnLSyX; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLqWm-0000J4-2L; Sat, 28 Jan 2023 14:06:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLqWi-0000IY-TO for bug-gnulib@gnu.org; Sat, 28 Jan 2023 14:06:13 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLqWg-0006qM-6J for bug-gnulib@gnu.org; Sat, 28 Jan 2023 14:06:12 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6C89716008A; Sat, 28 Jan 2023 11:06:07 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id P1sxJ2Roe4Qq; Sat, 28 Jan 2023 11:06:06 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4CAA416008B; Sat, 28 Jan 2023 11:06:06 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 4CAA416008B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1674932766; bh=e1kCSKKgGfkP57EVqGLND7KcSV4BGmK8NhmUaUG/ndk=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:From; b=Q6lnLSyXACSyaV1noSNAlcyfaIbmDdwmNG8x+pIqNbMJfUGDp7KHkds6BXjCcFLhM eVkTwm19n2hgiZ4TXxc6vwv1iyYl9/mUX/U6Mwr4hVMH+7IAsYNnIDxMrEpjeYJ55/ kjwbIQIrUaMxw9Brk0nohBjnUV28hFZekt9IGvCc= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7wwxRWKopgBN; Sat, 28 Jan 2023 11:06:06 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0FF6B16008A; Sat, 28 Jan 2023 11:06:06 -0800 (PST) Content-Type: multipart/mixed; boundary="------------QhacUJCnMwIgXjTay0D3tw0X" Message-ID: <0994b74a-97da-1650-3c21-00089936c24e@cs.ucla.edu> Date: Sat, 28 Jan 2023 11:06:05 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Avoid clang warnings regarding [[__nodiscard__]] Content-Language: en-US To: Bruno Haible References: <4082365.HAeao5ULc5@nimes> Cc: bug-gnulib@gnu.org From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <4082365.HAeao5ULc5@nimes> Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org This is a multi-part message in MIME format. --------------QhacUJCnMwIgXjTay0D3tw0X Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-01-28 02:57, Bruno Haible wrote: > + /* With clang up to 15.0.6 (at least), in C++ mode, [[__nodiscard__]] produces > + a warning. */ > +# if __clang_major__ >= 1000 I found this a little hard to follow, as I don't know __clang_major__ by heart and at first misread that as version 10.0.0. How about something like the attached, to simplify this for Clang non-experts? --------------QhacUJCnMwIgXjTay0D3tw0X Content-Type: text/x-patch; charset=UTF-8; name="nodiscard.diff" Content-Disposition: attachment; filename="nodiscard.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL200L2dudWxpYi1jb21tb24ubTQgYi9tNC9nbnVsaWItY29tbW9uLm00 CmluZGV4IGQ2MzI4MTk4NjQuLmJiNWEyMDI5YWYgMTAwNjQ0Ci0tLSBhL200L2dudWxpYi1j b21tb24ubTQKKysrIGIvbTQvZ251bGliLWNvbW1vbi5tNApAQCAtMzc5LDE0ICszNzksMTEg QEAgQUNfREVGVU4oW2dsX0NPTU1PTl9CT0RZXSwgWwogICAgdGhlIHJldHVybiB2YWx1ZSwg dW5sZXNzIHRoZSBjYWxsZXIgdXNlcyBzb21ldGhpbmcgbGlrZSBpZ25vcmVfdmFsdWUuICAq LwogLyogQXBwbGllcyB0bzogZnVuY3Rpb24sIGVudW1lcmF0aW9uLCBjbGFzcy4gICovCiAj aWZuZGVmIF9HTF9BVFRSSUJVVEVfTk9ESVNDQVJECi0jIGlmIGRlZmluZWQgX19jbGFuZ19f ICYmIGRlZmluZWQgX19jcGx1c3BsdXMKICAgLyogV2l0aCBjbGFuZyB1cCB0byAxNS4wLjYg KGF0IGxlYXN0KSwgaW4gQysrIG1vZGUsIFtbX19ub2Rpc2NhcmRfX11dIHByb2R1Y2VzCiAg ICAgIGEgd2FybmluZy4gICovCi0jICBpZiBfX2NsYW5nX21ham9yX18gPj0gMTAwMAotIyAg IGRlZmluZSBfR0xfQVRUUklCVVRFX05PRElTQ0FSRCBbW19fbm9kaXNjYXJkX19dXQotIyAg ZW5kaWYKLSMgZWxpZiBkZWZpbmVkIF9faGFzX2NfYXR0cmlidXRlCi0jICBpZiBfX2hhc19j X2F0dHJpYnV0ZSAoX19ub2Rpc2NhcmRfXykKKyMgaWZkZWYgX19oYXNfY19hdHRyaWJ1dGUK KyMgIGlmIChfX2hhc19jX2F0dHJpYnV0ZSAoX19ub2Rpc2NhcmRfXykgXAorICAgICAgICYm ICEgKGRlZmluZWQgX19jbGFuZ19fICYmIGRlZmluZWQgX19jcGx1c3BsdXMpKQogIyAgIGRl ZmluZSBfR0xfQVRUUklCVVRFX05PRElTQ0FSRCBbW19fbm9kaXNjYXJkX19dXQogIyAgZW5k aWYKICMgZW5kaWYK --------------QhacUJCnMwIgXjTay0D3tw0X--