From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1044A1F4B4 for ; Mon, 28 Dec 2020 21:15:07 +0000 (UTC) Received: from localhost ([::1]:59720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktzr8-0000t8-0o for normalperson@yhbt.net; Mon, 28 Dec 2020 16:15:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktzr5-0000t0-7f for bug-gnulib@gnu.org; Mon, 28 Dec 2020 16:15:03 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktzr3-0007vn-MC for bug-gnulib@gnu.org; Mon, 28 Dec 2020 16:15:03 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 782A816008A; Mon, 28 Dec 2020 13:15:00 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id n4SlEgh2f_OH; Mon, 28 Dec 2020 13:14:59 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 98D631600CD; Mon, 28 Dec 2020 13:14:59 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hduqPCHTcbyR; Mon, 28 Dec 2020 13:14:59 -0800 (PST) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 706B716008A; Mon, 28 Dec 2020 13:14:59 -0800 (PST) Subject: Re: [PATCH v2 6/6] stdlib: Assume FACCESSAT_NEVER_EOVERFLOWS on realpath To: Adhemerval Zanella References: <20201228135944.1018303-1-adhemerval.zanella@linaro.org> <20201228135944.1018303-6-adhemerval.zanella@linaro.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <055291a3-265b-be2f-5119-fd7955b8140c@cs.ucla.edu> Date: Mon, 28 Dec 2020 13:14:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201228135944.1018303-6-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-2.698, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org, bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 12/28/20 5:59 AM, Adhemerval Zanella wrote: > The faccessat (..., AT_EACCESS) on Linux fallback will either use > __NR_faccessat for __libc_enable_secure or LFS fstatat call. Neither > fallbacks returns EOVERFLOW in failure case. Argh, I had misread the glibc source code in this area. So I installed this further Gnulib patch: https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=d82dfeb8a7c9b276c8c7db94d077eb7a43a6760c which should result in even simpler code than the v2 6/6 patch. So, to summarize this series of 6 patches to glibc: * Patches 1, 2, and 3 are fine. * Patch 4 (stdlib: Sync canonicalize with gnulib) can now sync with today's Gnulib instead. * Patch 5 and 6 are no longer needed, since today's Gnulib subsumes them.