Re: Failing test: "test-posix_spawn-script". Race condition?

Re: Failing test: "test-posix_spawn-script". Race condition?

[Eric Blake]

On Tue, Dec 20, 2022 at 06:51:31PM -0500, Mitchell Dorrell wrote:
> I'm compiling m4 1.4.19 on a dual-socket server with second-generation AMD
> Epyc processors (128 cores total). I'm compiling using GCC 12.2.0. "make
> -j128 check" fails, but "make check" succeeds. While troubleshooting, I
> noticed that the test reads an empty file instead of one containing the
> expected number of bytes. I'm guessing that another test (running
> concurrently) is interfering with the results of this test.
> 
> Is this a known issue?

Thanks for the report; I'm looping in bug-gnulib as the owners of the
test in question.  It's the first time I've heard of this issue, but I
also know that m4 needs a new release with a newer pull from gnulib,
so the issue may have been addressed in the meantime in gnulib.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: Failing test: "test-posix_spawn-script". Race condition?

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Thanks, I installed the attached, which I hope fixes the race condition 
in the Gnulib test.

[-- Attachment #2: 0001-posix_spawnp-tests-fix-filename-typo.patch --]
[-- Type: text/x-patch, Size: 1527 bytes --]

From a3efddb96f5f121b8a5bb1310dc82407546fd255 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 22 Dec 2022 21:19:34 -0800
Subject: [PATCH] posix_spawnp-tests: fix filename typo

Problem reported for GNU m4 by Mitchell Dorrell in:
https://lists.gnu.org/r/bug-m4/2022-12/msg00000.html
* tests/test-posix_spawnp-script.c (DATA_FILENAME):
Fix typo in file name that caused race with
test-posix_spawn-script.c.
---
 ChangeLog                        | 9 +++++++++
 tests/test-posix_spawnp-script.c | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 304e502fcd..562845795d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2022-12-22  Paul Eggert  <eggert@cs.ucla.edu>
+
+	posix_spawnp-tests: fix filename typo
+	Problem reported for GNU m4 by Mitchell Dorrell in:
+	https://lists.gnu.org/r/bug-m4/2022-12/msg00000.html
+	* tests/test-posix_spawnp-script.c (DATA_FILENAME):
+	Fix typo in file name that caused race with
+	test-posix_spawn-script.c.
+
 2022-12-22  Ondrej Valousek  <ondrej.valousek.xm@renesas.com>
 
 	file-has-acl: Basic support for checking NFSv4 ACLs in Linux.
diff --git a/tests/test-posix_spawnp-script.c b/tests/test-posix_spawnp-script.c
index 1e5fc5c110..d2035ed63e 100644
--- a/tests/test-posix_spawnp-script.c
+++ b/tests/test-posix_spawnp-script.c
@@ -28,7 +28,7 @@
 
 #include "macros.h"
 
-#define DATA_FILENAME "test-posix_spawn-script.tmp"
+#define DATA_FILENAME "test-posix_spawnp-script.tmp"
 
 int
 main ()
-- 
2.25.1