From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6805B1F44D for ; Mon, 15 Apr 2024 14:07:22 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TGO9vt4N; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwMzE-00079k-6c; Mon, 15 Apr 2024 10:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwMzC-00079U-TV for bug-gnulib@gnu.org; Mon, 15 Apr 2024 10:07:06 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwMzB-0000x8-5s for bug-gnulib@gnu.org; Mon, 15 Apr 2024 10:07:06 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1e4f341330fso26317615ad.0 for ; Mon, 15 Apr 2024 07:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713190024; x=1713794824; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=8dZX0vT+Zbqn+aQgCSoLlMKUG06JFFFbEgXge0U7IU4=; b=TGO9vt4NiYR5DzaM3iuusG4sDmW7x+6xnFrpKCCRNc8qo7oUykMyi1S8isc4Ma9K2c macQpmg5EvbWCRlacPnq48A1HI0dra92NVDYhddt6G3fvcxW3c6OJ24AHO8XjLVG7Cai ehBtTHNycxLj24wJD/W5GGNQ8hphqoRGlfX3dO28h/3l4fh5gj4NZvn6CzU9dZIwNOIj aoR3IWTRGPNByiDt4dQ28DjpGYN1oQO15aMiRBm9KAHulRaKOW5EWozCG3PdlqwSa1Ve h/PqUnaOexS96rDjEXXfHEdphArH/IIGoAa+XIWpXEvagglCVsBlU7qGeRlLrCvzWNgg 9JTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713190024; x=1713794824; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8dZX0vT+Zbqn+aQgCSoLlMKUG06JFFFbEgXge0U7IU4=; b=KyJHflHFntTFGV6nidUTdbHBBeQvxfkfpsiylEK9kr0kfI5pi0BiXUez1aBZHB94dE 62vj5TgiC/Q6RT53PoYprLI/jm1ro57jBDorKYGy+RtVu6HuZvMcvspq/XSBnntC8A5k p1/lS1YlI+pSRq0/SAH9GGXOCwIqoKTxvjljNVJgbgP/OqYzfDmwn8cEw9bmXb/CHY7l XIW9ymbY2DMbEiTGwV4hhUejIB4NO9664NsDtpS5VlyDfVo8JzDvQBLPPqUDF/ZcmPPh NU8qnItQWnF+YFXRJGFKkntPZKyY4IGVvZ14SCswjUrkkhpnxYxTTeBN29l+E1fGgMwr Iz1w== X-Forwarded-Encrypted: i=1; AJvYcCXgxJKUtQ2Bhjo+otXIsdAvKRRLsDdMbfQ3uMlyEMimMzdJxZtyRjlnQUAALJ+QEhhlGs7Ba0hMEBs+6d5aCg/E+W0= X-Gm-Message-State: AOJu0Yz4lr/E5QqmSQPdvHXsVx6gskG0QA0BcS6FCoiRmUb7LqF3wKag PRiiwTxHNcn0UOPb600sg17U4cOGeVXVKeOyG/8VeffBU6kbh4VXM7RgRg== X-Google-Smtp-Source: AGHT+IH6oR6f9BuyQXziCmpgxdi1u8OAE2AMh/PA8gX3TKkqF7gPePAyY085qLQO7uQMXehMwDbTgw== X-Received: by 2002:a17:902:e74a:b0:1e2:a162:6f7a with SMTP id p10-20020a170902e74a00b001e2a1626f7amr9903720plf.43.1713190023560; Mon, 15 Apr 2024 07:07:03 -0700 (PDT) Received: from [192.168.1.5] (c-73-189-213-139.hsd1.ca.comcast.net. [73.189.213.139]) by smtp.gmail.com with ESMTPSA id h13-20020a170902680d00b001e49bce99d9sm8122609plk.95.2024.04.15.07.07.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 07:07:02 -0700 (PDT) Message-ID: <010bbae2-f51e-4d50-ae2c-52c59bf05513@gmail.com> Date: Mon, 15 Apr 2024 07:07:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: gnulib-tool.py: Remove a redundant function. To: Bruno Haible , bug-gnulib@gnu.org References: <5642994.VNxaBq3RWB@nimes> Content-Language: en-US From: Collin Funk In-Reply-To: <5642994.VNxaBq3RWB@nimes> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=collin.funk1@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Hi Bruno, On 4/15/24 4:47 AM, Bruno Haible wrote: > No. I'm adding 3 unit tests that prove that the patch is wrong, > one for each of docbase, sourcebase, testsbase. (For auxdir and m4base > gnulib-tool.{sh,py} does not support changing the value while preserving > the rest: For auxdir the old files are not removed, for m4base the list > of modules gets reset to empty.) Ah, I see. I should have diff'd the two functions like you. The 'self.config' and 'self.cache' was too easy for my eyes to overlook... Thanks for adding the tests. My local branch fails but passes using master, so I can see this change is incorrect. I sent 2 other patches whenever you have time to check them. I can rewrite patch 0002 as long as it is otherwise correct. It should use rewrite_{new,old}_files and not the improper renamed function from patch 0001. Patch 0003 should work fine. Just an unused variable that is handled elsewhere. Collin