bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: "(GalaxyMaster)" <galaxy@openwall.com.au>
To: bug-gnulib@gnu.org
Subject: Re: filevercmp incompatible change?
Date: Sat, 28 Jan 2023 15:18:18 +0000	[thread overview]
Message-ID: <01000185f8f5384a-f7e5dfc6-a577-4b21-998d-a0b596056526-000000@email.amazonses.com> (raw)
In-Reply-To: <20230128145803.GF15496@mail.openwall.com.au>

All,

On Sun, Jan 29, 2023 at 01:58:03AM +1100, (GalaxyMaster) wrote:
> [I am not subscribed, so please CC me if you need any further info]
> 
> I think the following commit introduced a behavioural change that was not
> intended: https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=1ba2b66ea45f9bc43cdc0f6f93efa59157d2b2ba

Oh, silly me -- at the end of that commit the test was also adjusted, so
everything seems good.  However, I did not find any mentioning that the sort
order is changing with the commit and I think it may make some people scratch
their head for a moment (like, I spent almost an hour before I pinpointed it to
filevercmp.c).

-- 
(GM)


       reply	other threads:[~2023-01-28 15:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230128145803.GF15496@mail.openwall.com.au>
2023-01-28 15:18 ` (GalaxyMaster) [this message]
2023-01-28 15:26   ` filevercmp incompatible change? Bruno Haible
2023-01-28 15:39     ` (GalaxyMaster)
2023-01-28 14:58 (GalaxyMaster)
2023-01-28 15:20 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01000185f8f5384a-f7e5dfc6-a577-4b21-998d-a0b596056526-000000@email.amazonses.com \
    --to=galaxy@openwall.com.au \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).