From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 79B211F47C for ; Thu, 26 Jan 2023 07:29:01 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=openwall.com.au header.i=@openwall.com.au header.a=rsa-sha256 header.s=pcbvnislxexiljmocxhjeg5lp2gwjesd header.b=QVP/T0Rs; dkim=pass (1024-bit key; unprotected) header.d=amazonses.com header.i=@amazonses.com header.a=rsa-sha256 header.s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw header.b=BEpuRkRQ; dkim=pass (2048-bit key; secure) header.d=openwall.com.au header.i=@openwall.com.au header.a=rsa-sha256 header.s=20180402 header.b=Ik6I0jKE; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKwgj-0002Ly-58; Thu, 26 Jan 2023 02:28:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <01000185ecfa8b43-c1e8a296-a5b6-414c-ade0-1f8d8a48b401-000000@amazon-ses-us-east-1.openwall.com.au>) id 1pKwgh-0002LX-IR for bug-gnulib@gnu.org; Thu, 26 Jan 2023 02:28:47 -0500 Received: from a8-35.smtp-out.amazonses.com ([54.240.8.35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.90_1) (envelope-from <01000185ecfa8b43-c1e8a296-a5b6-414c-ade0-1f8d8a48b401-000000@amazon-ses-us-east-1.openwall.com.au>) id 1pKwge-0002Ri-1D for bug-gnulib@gnu.org; Thu, 26 Jan 2023 02:28:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=pcbvnislxexiljmocxhjeg5lp2gwjesd; d=openwall.com.au; t=1674718120; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; bh=An9eknCHCJNd9HygYokjRoyLM65a5+T9HRXny94PVoc=; b=QVP/T0RsiYlYSepm35UhB2/uXW7JZWuBSCd9ZxM6LefReNbWdFQhyFgocYN94QKW L5x6oQaXbJzHqQDGezNq98YJS3gq+m0CxL/OcH6zviJF3fF5VPY+WNusGjRy7bGplyp bWMNnYEDmTOF20XUs8+2ngxP1OJreZSz4OzXZw+I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1674718120; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Feedback-ID; bh=An9eknCHCJNd9HygYokjRoyLM65a5+T9HRXny94PVoc=; b=BEpuRkRQ7BoA3WXNWKgNhjR+aG1ZP7xmTQIintWhyob0Nnol7RF5FdxH5dadDqbz aPjTU73SFsrMfs8WTj02aNJlvtMP/xdJVOBKesn2WLBCOzn4UKpzQCJQEUU4heW/35U Ko3tAEdGpnFx4KlrNrQUFqono+pxtXLuJS+boCCc= ARC-Seal: i=1; a=rsa-sha256; d=openwall.com.au; s=20180402; t=1674718120; cv=none; b=wkb3VxM/pOyegxJII/ejEZGODH5ATJjShLbsPaSH8gCdRX70Sx/iORIRDU8I1yIRNVAR25tDYTGZviax/NW+IKN63yB2I69+98sfmiuQTykXigJLuFtix2twAuZYTOIHMPDJIrFlccEeSaV/YfNVT9VQuwpg6O9SR7xxXRTSNMMbLBeHH+Be2baH2s/X4rDCeBwBdtSfP2MBgRK4xLFWWPi+pJfEpyod567BWcrRyJdp8ZF8MnnGNiO786eaMppBro9rA+Y7LX/xUdEbpkx1dutHzzMvNcWyo7bZv6+2fzj9B3+qm8ttdIoDERVLZkwVi8NaIdIIuoNk1n3XJZjHRQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=openwall.com.au; s=20180402; t=1674718120; c=relaxed/simple; bh=An9eknCHCJNd9HygYokjRoyLM65a5+T9HRXny94PVoc=; h=From:To:Cc:Subject; b=gHEUX7ivDpPG+UYKRY18tqW+UFTQLyeUDBiw2F/yJdLGL5mvFWwJF6JLXBv2Bjt9hHMUA4oECBSuPPzCNlit9l88KJM8hX5XPP5XaeMp3nXnLC0LuxQSYsLCAinLgjujibTbR1VhesCSgFt3s3cnJ3CCWYoebigEG9DiqoZdjoC4ph9N4eA1OK/1REmGIRiSjJ8Dp2rH8lAT70VmsOYKPTgfdRCfeWE0RHqblGrUJvWM3bxHvk0wtyRY/LMCgXtDY0YJHBHv5p/2aqbs6caRBSH+LvkCiJCiroDdODdv9Rm/xjYnczmJ3A4d0iuAtceKCC3xCSUcT24PcbE5zzUyTg== ARC-Authentication-Results: i=1; mail.openwall.com.au; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=openwall.com.au; s=20180402; t=1674718120; bh=An9eknCHCJNd9HygYokjRoyLM65a5+T9HRXny94PVoc=; h=From:To:Cc:Subject:From; b=Ik6I0jKEt/CW3ViXqluhHtcJlDLqHI257cQUp2/KDiZhSlEskgq5qRQ2ds4fbffkN fBMgklqCLCbStJVVkzX6KV9NsGl5WpJPzg4On8tQ/rl6emK0K2adOR39TGPj1X5tB8 qYLbm/hdmUYPxlhfhLvIIl9H4cnFdBWsObQbeo2aexNK0Tf7ONd5Fd/OoP60/kePDA qW8YdSJBiW87G+Y2sO+F9nLzqD3BcUEUmkPSQNs5HEa0E5MHdDsIzcoIare8xJC7zM LhVnZobkfrS2R7V9Tlo/SJcGzMuRVEQhNAAL45GRamZEE7lMhlcrB5S1CnXYtj+ijw RMMX6GJwhCivQ== Date: Thu, 26 Jan 2023 07:28:40 +0000 From: "(GalaxyMaster)" To: Bruno Haible Cc: bug-gnulib@gnu.org Subject: Re: backupfile and backup-rename are introducing the same object to make Message-ID: <01000185ecfa8b43-c1e8a296-a5b6-414c-ade0-1f8d8a48b401-000000@email.amazonses.com> References: <01000185e8d1146f-84242ea5-e0a3-406f-8126-b306b40107f8-000000@email.amazonses.com> <3038350.4B0zn089NQ@nimes> <3315871.bkMWQJmNkr@nimes> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3315871.bkMWQJmNkr@nimes> User-Agent: Mutt/1.5.21 (2010-09-15) Feedback-ID: 1.us-east-1.Br0WpcLm0XzNPYp+t39aA5qSwb/HYCx3zC5wkQY3G2s=:AmazonSES X-SES-Outgoing: 2023.01.26-54.240.8.35 Received-SPF: pass client-ip=54.240.8.35; envelope-from=01000185ecfa8b43-c1e8a296-a5b6-414c-ade0-1f8d8a48b401-000000@amazon-ses-us-east-1.openwall.com.au; helo=a8-35.smtp-out.amazonses.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Bruno, On Wed, Jan 25, 2023 at 08:44:34PM +0100, Bruno Haible wrote: > Btw, if we have a problem here, we also have it in other places. > The .c files that are listed in lib_SOURCES of more than one module are: > > 2 backupfile.c > 2 pipe-filter-aux.c With pipe-filter-aux.c I experienced a different issue. In comparison to all other modules that work with nonintr_close(), nonintr_open(), nonintr_read(), and nonintr_write(), this module defines the function as just "inlined", while execute and spawn-pipe modules declares them as static. So, to build pipe-filter-aux as a shareable object I redefined "PIPE_FILTER_AUX_INLINE" to be "static _GL_INLINE" instead of just "_GL_INLINE" and this basically resolved the issue. I think this change may be considered for the inclusion into the library since I see no reason why every other module is declaring these functions as static and pipe-filter-aux.c is not. But again, my use case is non-standard and is likely not supported :). -- (GM)