From: "(GalaxyMaster)" <galaxy@openwall.com.au>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org
Subject: Re: backupfile and backup-rename are introducing the same object to make
Date: Thu, 26 Jan 2023 07:28:40 +0000 [thread overview]
Message-ID: <01000185ecfa8b43-c1e8a296-a5b6-414c-ade0-1f8d8a48b401-000000@email.amazonses.com> (raw)
In-Reply-To: <3315871.bkMWQJmNkr@nimes>
Bruno,
On Wed, Jan 25, 2023 at 08:44:34PM +0100, Bruno Haible wrote:
> Btw, if we have a problem here, we also have it in other places.
> The .c files that are listed in lib_SOURCES of more than one module are:
>
> 2 backupfile.c
> 2 pipe-filter-aux.c
With pipe-filter-aux.c I experienced a different issue. In comparison to all
other modules that work with nonintr_close(), nonintr_open(), nonintr_read(),
and nonintr_write(), this module defines the function as just "inlined", while
execute and spawn-pipe modules declares them as static. So, to build
pipe-filter-aux as a shareable object I redefined "PIPE_FILTER_AUX_INLINE" to
be "static _GL_INLINE" instead of just "_GL_INLINE" and this basically resolved
the issue. I think this change may be considered for the inclusion into the
library since I see no reason why every other module is declaring these
functions as static and pipe-filter-aux.c is not. But again, my use case is
non-standard and is likely not supported :).
--
(GM)
next prev parent reply other threads:[~2023-01-26 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 12:04 backupfile and backup-replace are introducing the same object to make (GalaxyMaster)
2023-01-25 17:53 ` backupfile and backup-rename " Bruno Haible
2023-01-25 19:44 ` Bruno Haible
2023-01-26 7:28 ` (GalaxyMaster) [this message]
2023-01-26 7:19 ` (GalaxyMaster)
2023-01-26 10:19 ` Bruno Haible
2023-01-26 11:20 ` GalaxyMaster
2023-01-26 14:43 ` Bruno Haible
2023-01-28 14:41 ` (GalaxyMaster)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01000185ecfa8b43-c1e8a296-a5b6-414c-ade0-1f8d8a48b401-000000@email.amazonses.com \
--to=galaxy@openwall.com.au \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).