From: "Pádraig Brady" <P@draigBrady.com>
To: Sam James <sam@gentoo.org>
Cc: 60455-done@debbugs.gnu.org
Subject: bug#60455: Missing fallback if copy_file_range returns ENOENT?
Date: Sun, 8 Jan 2023 13:45:40 +0000 [thread overview]
Message-ID: <daa4c1cd-b01b-92b2-7e04-e0fed9650852@draigBrady.com> (raw)
In-Reply-To: <79241D6A-DBF0-46BC-B798-D31DDB81AC35@gentoo.org>
On 08/01/2023 00:51, Sam James wrote:
>
>
>> On 7 Jan 2023, at 16:25, Pádraig Brady <P@draigBrady.com> wrote:
>> OK it's probably worth handling in coreutils then.
>> Note I still get the feeling this is a race in CIFS
>> that is only being made more apparent with copy_file_range(),
>> but fair enough that this is a regressions for users and
>> we should be able to cater for it easy enough.
Or more precisely, ENOENT will be unusual for fd operations,
and so falling back to a standard copy should just be
restricted to this or similar cases.
If this was seen on a single CIFS mount it may be
less appropriate as then the user may not want to
fall back to a client side copy, when a server side should work.
But in this separate mount case, the fallback is appropriate.
I guess we could restrict to separate device IDs,
but that's probably getting too complicated for this.
> Total agreement. Thanks, looks good!
Pushed.
Marking this as done.
cheers,
Pádraig
prev parent reply other threads:[~2023-01-08 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 17:00 bug#60455: Missing fallback if copy_file_range returns ENOENT? Sam James
2022-12-31 18:51 ` Pádraig Brady
2023-01-07 7:34 ` Sam James
2023-01-07 16:25 ` Pádraig Brady
2023-01-08 0:51 ` Sam James
2023-01-08 13:45 ` Pádraig Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-coreutils
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daa4c1cd-b01b-92b2-7e04-e0fed9650852@draigBrady.com \
--to=p@draigbrady.com \
--cc=60455-done@debbugs.gnu.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).