From 1f1295cee4aedb8650e8dcde73fbf4d349f80917 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 6 Apr 2020 23:16:27 +0000 Subject: xt/perf-msgview: update to use git->cat_async It's about 5-10% faster on an SMP machine with an SSD, even on a hot Linux page cache. --- xt/perf-msgview.t | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) (limited to 'xt') diff --git a/xt/perf-msgview.t b/xt/perf-msgview.t index 3ea92ec6..a4445959 100644 --- a/xt/perf-msgview.t +++ b/xt/perf-msgview.t @@ -32,22 +32,30 @@ my $ctx = { -inbox => $ibx, www => Plack::Util::inline_object(style => sub {''}), }; -my ($str, $mime, $res, $cmt, $type); +my ($mime, $res, $oid, $type); my $n = 0; +my $obuf = ''; +my $m = 0; + +my $cb = sub { + $mime = PublicInbox::MIME->new(shift); + PublicInbox::View::multipart_text_as_html($mime, $ctx); + ++$m; + $obuf = ''; +}; + +$git->cat_async_begin; my $t = timeit(1, sub { - my $obuf = ''; $ctx->{obuf} = \$obuf; $ctx->{mhref} = '../'; while (<$fh>) { - ($cmt, $type) = split / /; + ($oid, $type) = split / /; next if $type ne 'blob'; ++$n; - $str = $git->cat_file($cmt); - $mime = PublicInbox::MIME->new($str); - PublicInbox::View::multipart_text_as_html($mime, $ctx); - $obuf = ''; + $git->cat_async($oid, $cb); } + $git->cat_async_wait; }); -diag 'multipart_text_as_html took '.timestr($t)." for $n messages"; -ok 1; +diag 'multipart_text_as_html took '.timestr($t)." for $n <=> $m messages"; +is($m, $n, 'rendered all messages'); done_testing(); -- cgit v1.2.3-24-ge0c7