From 3d20f6e4c214747b3e700d30e4cac70a33a817d8 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 14 Dec 2019 05:22:18 +0000 Subject: address: explicitly reject local-only addresses Apparently, neither our previous address parsing code nor Email::Address::XS recognizes local, username-only addresses in the form of (without "@host"). Without this change, Email::Address::XS->address would return "undef", so we need to filter it out via "grep { defined }" It seems the cases where users email each other on the same machine is small and public-inbox won't be able to index addresses for those cases... Oh well :/ --- t/address.t | 5 +++++ 1 file changed, 5 insertions(+) (limited to 't') diff --git a/t/address.t b/t/address.t index e7c0d6a8..1f20702a 100644 --- a/t/address.t +++ b/t/address.t @@ -38,6 +38,11 @@ sub test_pkg { @names = $names->('"Quote Unneeded" '); is_deeply(['Quote Unneeded'], \@names, 'extra quotes dropped'); + + my @emails = $emails->('Local User '); + is_deeply([], \@emails , 'no address for local address'); + @names = $emails->('Local User '); + is_deeply([], \@names, 'no address, no name'); } test_pkg('PublicInbox::Address'); -- cgit v1.2.3-24-ge0c7