From d3c55d072839286efb2865fe20f2324a9e595e95 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 2 Nov 2023 09:35:30 +0000 Subject: treewide: use ->close to call ProcessIO->CLOSE This will open the door for us to drop `tie' usage from ProcessIO completely in favor of OO method dispatch. While OO method dispatches (e.g. `$fh->close') are slower than normal subroutine calls, it hardly matters in this case since process teardown is a fairly rare operation and we continue to use `close($fh)' for Maildir writes. --- script/public-inbox-convert | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'script') diff --git a/script/public-inbox-convert b/script/public-inbox-convert index 96f6d2ea..d8186809 100755 --- a/script/public-inbox-convert +++ b/script/public-inbox-convert @@ -1,5 +1,5 @@ #!/usr/bin/perl -w -# Copyright (C) 2018-2021 all contributors +# Copyright (C) all contributors # License: AGPL-3.0+ use strict; use v5.10.1; @@ -158,7 +158,7 @@ while (<$rd>) { last if $_ eq "done\n"; print $io $_ or $im->wfail; } -close $rd or die "fast-export: \$?=$? \$!=$!\n"; +$rd->close or die "fast-export: \$?=$? \$!=$!\n"; $io = undef; $v2w->done; if (my $old_mm = $old->mm) { -- cgit v1.2.3-24-ge0c7