From d155f989769861be45938345350f07365ca945c1 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 15 Nov 2019 09:50:35 +0000 Subject: index: pass global variables into subs Avoid 'Variable "%s" will not stay shared' warnings when the contents of this script eval'ed into a sub. --- script/public-inbox-index | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'script') diff --git a/script/public-inbox-index b/script/public-inbox-index index 139b6e56..102381c3 100755 --- a/script/public-inbox-index +++ b/script/public-inbox-index @@ -18,11 +18,10 @@ GetOptions($opt, qw(verbose|v+ reindex jobs|j=i prune indexlevel|L=s)) or die "bad command-line args\n$usage"; die "--jobs must be positive\n" if defined $opt->{jobs} && $opt->{jobs} <= 0; -sub usage { print STDERR "Usage: $usage\n"; exit 1 } my @ibxs = PublicInbox::Admin::resolve_inboxes(\@ARGV); PublicInbox::Admin::require_or_die('-index'); -usage() unless @ibxs; +unless (@ibxs) { print STDERR "Usage: $usage\n"; exit 1 } my $mods = {}; foreach my $ibx (@ibxs) { # XXX: users can shoot themselves in the foot, with opt->{indexlevel} -- cgit v1.2.3-24-ge0c7