From 16b69a6a99661df777affec547ef53bd9007f1f2 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 15 Nov 2019 09:50:38 +0000 Subject: learn: pass global variables into subs Avoid 'Variable "%s" will not stay shared' warnings when the contents of this script eval'ed into a sub. --- script/public-inbox-learn | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'script') diff --git a/script/public-inbox-learn b/script/public-inbox-learn index 3073294a..93aece2e 100644 --- a/script/public-inbox-learn +++ b/script/public-inbox-learn @@ -39,8 +39,8 @@ my $mime = PublicInbox::MIME->new(eval { $data }); -sub remove_or_add ($$$) { - my ($ibx, $train, $addr) = @_; +sub remove_or_add ($$$$) { + my ($ibx, $train, $mime, $addr) = @_; # We do not touch GIT_COMMITTER_* env here so we can track # who trained the message. @@ -93,12 +93,12 @@ if ($train eq 'spam') { while (my ($addr, $ibx) = each %dests) { next unless ref($ibx); # $ibx may be 0 next if $seen{"$ibx"}++; - remove_or_add($ibx, $train, $addr); + remove_or_add($ibx, $train, $mime, $addr); } my $dests = PublicInbox::MDA->inboxes_for_list_id($pi_config, $mime); for my $ibx (@$dests) { next if !$seen{"$ibx"}++; - remove_or_add($ibx, $train, $ibx->{-primary_address}); + remove_or_add($ibx, $train, $mime, $ibx->{-primary_address}); } } -- cgit v1.2.3-24-ge0c7