From d0164b3c9048bfd733a82b8fcd53d032e97552cc Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 25 Dec 2016 08:09:48 +0000 Subject: httpd/async: improve variable naming We only refer to PublicInbox::HTTP objects here, so '$io' was a bad name. --- lib/PublicInbox/HTTPD/Async.pm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'lib') diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm index 68514f5a..79951ca6 100644 --- a/lib/PublicInbox/HTTPD/Async.pm +++ b/lib/PublicInbox/HTTPD/Async.pm @@ -30,10 +30,10 @@ sub restart_read_cb ($) { } sub async_pass { - my ($self, $io, $fh, $bref) = @_; - # In case the client HTTP connection ($io) dies, it + my ($self, $http, $fh, $bref) = @_; + # In case the client HTTP connection ($http) dies, it # will automatically close this ($self) object. - $io->{forward} = $self; + $http->{forward} = $self; $fh->write($$bref); my $restart_read = restart_read_cb($self); weaken($self); @@ -41,10 +41,10 @@ sub async_pass { my $r = sysread($self->{sock}, $$bref, 8192); if ($r) { $fh->write($$bref); - return if $io->{closed}; - if ($io->{write_buf_size}) { + return if $http->{closed}; + if ($http->{write_buf_size}) { $self->watch_read(0); - $io->write($restart_read); # D::S::write + $http->write($restart_read); # D::S::write } # stay in watch_read, but let other clients # get some work done, too. @@ -55,7 +55,7 @@ sub async_pass { # Done! Error handling will happen in $fh->close # called by the {cleanup} handler - $io->{forward} = undef; + $http->{forward} = undef; $self->close; } } -- cgit v1.2.3-24-ge0c7