From 587cc7c14629a59fd39c9c5b991f0676217722e0 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 11 Jan 2020 22:34:58 +0000 Subject: solver: path_a may be undef from /dev/null This avoids uninitialized variable warnings when viewing newly-created files. --- lib/PublicInbox/SolverGit.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm index b48e8ac4..baad981d 100644 --- a/lib/PublicInbox/SolverGit.pm +++ b/lib/PublicInbox/SolverGit.pm @@ -169,7 +169,7 @@ sub extract_diff ($$) { my $patch = $9; # don't care for leading 'a/' and 'b/' - my (undef, @a) = split(m{/}, git_unquote($path_a)); + my (undef, @a) = split(m{/}, git_unquote($path_a)) if defined($path_a); my (undef, @b) = split(m{/}, git_unquote($path_b)); # get rid of path-traversal attempts and junk patches: @@ -177,7 +177,7 @@ sub extract_diff ($$) { state $bad_component = { map { $_ => 1 } ('', '.', '..') }; foreach (@a, @b) { return if $bad_component->{$_} } - $di->{path_a} = join('/', @a); + $di->{path_a} = join('/', @a) if @a; $di->{path_b} = join('/', @b); my $path = ++$self->{tot}; -- cgit v1.2.3-24-ge0c7