From 31cb75037a757c9388f74283a8b1ecb7c5b65f24 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 30 Jan 2020 09:19:06 +0000 Subject: mboxgz: ensure gzipped mboxes always have filenames Lets always have Content-Disposition for files intended to be downloaded for consumption by non-browsers, such as pigz, zcat, "git am". This is also to be consistent with the non-gzipped mbox $MESSAGE_ID/raw endpoint. --- lib/PublicInbox/MboxGz.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'lib') diff --git a/lib/PublicInbox/MboxGz.pm b/lib/PublicInbox/MboxGz.pm index 08e3c846..30074e4d 100644 --- a/lib/PublicInbox/MboxGz.pm +++ b/lib/PublicInbox/MboxGz.pm @@ -21,12 +21,10 @@ sub response { my ($class, $ctx, $cb, $fn) = @_; my $body = $class->new($ctx, $cb); # http://www.iana.org/assignments/media-types/application/gzip - my @h = qw(Content-Type application/gzip); - if (defined $fn && $fn ne '') { - $fn = to_filename($fn); - push @h, 'Content-Disposition', "inline; filename=$fn.mbox.gz"; - } - [ 200, \@h, $body ]; + $fn = defined($fn) && $fn ne '' ? to_filename($fn) : 'no-subject'; + my $h = [ qw(Content-Type application/gzip), + 'Content-Disposition', "inline; filename=$fn.mbox.gz" ]; + [ 200, $h, $body ]; } sub gzip_fail ($$) { -- cgit v1.2.3-24-ge0c7