From 6e6f7999361925e4c944f308df4bc32a1842cd69 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 16 Apr 2019 01:10:09 +0000 Subject: cleanup: use '$ibx' consistently when referring to Inbox refs '$inbox' is more human-readable, so that is for the more human-readable name in most cases. Making our variable naming more consistent should make the code easier-to-review and harder to screw up. --- lib/PublicInbox/WWW.pm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'lib/PublicInbox/WWW.pm') diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm index aa05a23d..6e69001c 100644 --- a/lib/PublicInbox/WWW.pm +++ b/lib/PublicInbox/WWW.pm @@ -186,9 +186,9 @@ sub news_cgit_fallback ($) { # returns undef if valid, array ref response if invalid sub invalid_inbox ($$) { my ($ctx, $inbox) = @_; - my $obj = $ctx->{www}->{pi_config}->lookup_name($inbox); - if (defined $obj) { - $ctx->{-inbox} = $obj; + my $ibx = $ctx->{www}->{pi_config}->lookup_name($inbox); + if (defined $ibx) { + $ctx->{-inbox} = $ibx; return; } @@ -402,13 +402,13 @@ sub legacy_redirects { sub r301 { my ($ctx, $inbox, $mid_ue, $suffix) = @_; - my $obj = $ctx->{-inbox}; - unless ($obj) { + my $ibx = $ctx->{-inbox}; + unless ($ibx) { my $r404 = invalid_inbox($ctx, $inbox); return $r404 if $r404; - $obj = $ctx->{-inbox}; + $ibx = $ctx->{-inbox}; } - my $url = $obj->base_url($ctx->{env}); + my $url = $ibx->base_url($ctx->{env}); my $qs = $ctx->{env}->{QUERY_STRING}; if (defined $mid_ue) { # common, and much nicer as '@' than '%40': -- cgit v1.2.3-24-ge0c7