From 25c41ff78d0a65029e410b5478430b1061df1dae Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 12 Sep 2019 08:34:21 +0000 Subject: tmpfile: support O_APPEND and use it in DS::tmpio Might as well share some code for temporary file creation --- lib/PublicInbox/Tmpfile.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib/PublicInbox/Tmpfile.pm') diff --git a/lib/PublicInbox/Tmpfile.pm b/lib/PublicInbox/Tmpfile.pm index 7fda100e..28e87f88 100644 --- a/lib/PublicInbox/Tmpfile.pm +++ b/lib/PublicInbox/Tmpfile.pm @@ -12,10 +12,9 @@ require File::Spec; # use tmpfile instead of open(..., '+>', undef) so we can get an # unlinked filename which makes sense when viewed with lsof # (at least on Linux) -# TODO: O_APPEND support (this is the reason I'm not using File::Temp) # And if we ever stop caring to have debuggable filenames, O_TMPFILE :) -sub tmpfile ($;$) { - my ($id, $sock) = @_; +sub tmpfile ($;$$) { + my ($id, $sock, $append) = @_; if (defined $sock) { # add the socket inode number so we can figure out which # socket it belongs to @@ -25,10 +24,11 @@ sub tmpfile ($;$) { $id =~ tr!/!^!; my $fl = O_RDWR | O_CREAT | O_EXCL; + $fl |= O_APPEND if $append; do { my $fn = File::Spec->tmpdir . "/$id-".time.'-'.rand; if (sysopen(my $fh, $fn, $fl, 0600)) { # likely - unlink($fn) or die "unlink($fn): $!"; # FS broken + unlink($fn) or warn "unlink($fn): $!"; # FS broken return $fh; # success } } while ($! == EEXIST); -- cgit v1.2.3-24-ge0c7