From 6e6f7999361925e4c944f308df4bc32a1842cd69 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 16 Apr 2019 01:10:09 +0000 Subject: cleanup: use '$ibx' consistently when referring to Inbox refs '$inbox' is more human-readable, so that is for the more human-readable name in most cases. Making our variable naming more consistent should make the code easier-to-review and harder to screw up. --- lib/PublicInbox/NewsWWW.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/PublicInbox/NewsWWW.pm') diff --git a/lib/PublicInbox/NewsWWW.pm b/lib/PublicInbox/NewsWWW.pm index d7fcb0da..8626cf96 100644 --- a/lib/PublicInbox/NewsWWW.pm +++ b/lib/PublicInbox/NewsWWW.pm @@ -44,11 +44,11 @@ sub call { my (undef, @parts) = split(m!/!, $env->{PATH_INFO}); my ($ng, $article) = @parts; my $pi_config = $self->{pi_config}; - if (my $inbox = $pi_config->lookup_newsgroup($ng)) { - my $url = PublicInbox::Hval::prurl($env, $inbox->{url}); + if (my $ibx = $pi_config->lookup_newsgroup($ng)) { + my $url = PublicInbox::Hval::prurl($env, $ibx->{url}); my $code = 301; if (defined $article && $article =~ /\A\d+\z/) { - my $mid = eval { $inbox->mm->mid_for($article) }; + my $mid = eval { $ibx->mm->mid_for($article) }; if (defined $mid) { # article IDs are not stable across clones, # do not encourage caching/bookmarking them -- cgit v1.2.3-24-ge0c7