From 7ee29d11b25b09b8919b9a125732e4c2c5784d28 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 19 Sep 2015 02:03:31 +0000 Subject: nntp: use long response API for LISTGROUP LISTGROUP can be expensive for giant groups, too. Use the long response API to improve fairness and prevent excessive buffering. --- lib/PublicInbox/Msgmap.pm | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) (limited to 'lib/PublicInbox/Msgmap.pm') diff --git a/lib/PublicInbox/Msgmap.pm b/lib/PublicInbox/Msgmap.pm index c0fc636f..2f64d90c 100644 --- a/lib/PublicInbox/Msgmap.pm +++ b/lib/PublicInbox/Msgmap.pm @@ -155,25 +155,17 @@ sub create_tables { 'val VARCHAR(255) NOT NULL)'); } -sub each_id_batch { - my ($self, $cb) = @_; +sub id_batch { + my ($self, $num, $cb) = @_; my $dbh = $self->{dbh}; - my $n = 0; - my $total = 0; - my $nr; my $sth = $dbh->prepare('SELECT num FROM msgmap WHERE num > ? '. 'ORDER BY num ASC LIMIT 1000'); - while (1) { - $sth->execute($n); - my $ary = $sth->fetchall_arrayref; - @$ary = map { $_->[0] } @$ary; - $nr = scalar @$ary; - last if $nr == 0; - $total += $nr; - $n = $ary->[-1]; - $cb->($ary); - } - $total; + $sth->execute($num); + my $ary = $sth->fetchall_arrayref; + @$ary = map { $_->[0] } @$ary; + my $nr = scalar @$ary; + $cb->($ary) if $nr; + $nr; } 1; -- cgit v1.2.3-24-ge0c7