From 641d171a6bcb1f4ebb87b317f8eaca825da501c1 Mon Sep 17 00:00:00 2001 From: "Eric Wong (Contractor, The Linux Foundation)" Date: Thu, 22 Mar 2018 08:14:19 +0000 Subject: v2writable: clarify header cleanups We want to make it clear to the code and DEBUG_DIFF users that we do not introduce messages with unsuitable headers into public archives. --- lib/PublicInbox/Import.pm | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'lib/PublicInbox/Import.pm') diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm index d69934b0..5d116a1c 100644 --- a/lib/PublicInbox/Import.pm +++ b/lib/PublicInbox/Import.pm @@ -288,6 +288,14 @@ sub extract_author_info ($) { ($name, $email); } +# kill potentially confusing/misleading headers +sub drop_unwanted_headers ($) { + my ($mime) = @_; + + $mime->header_set($_) for qw(bytes lines content-length status); + $mime->header_set($_) for @PublicInbox::MDA::BAD_HEADERS; +} + # returns undef on duplicate # returns the :MARK of the most recent commit sub add { @@ -321,9 +329,7 @@ sub add { _check_path($r, $w, $tip, $path) and return; } - # kill potentially confusing/misleading headers - $mime->header_set($_) for qw(bytes lines content-length status); - $mime->header_set($_) for @PublicInbox::MDA::BAD_HEADERS; + drop_unwanted_headers($mime); # spam check: if ($check_cb) { -- cgit v1.2.3-24-ge0c7