From 6e6f7999361925e4c944f308df4bc32a1842cd69 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 16 Apr 2019 01:10:09 +0000 Subject: cleanup: use '$ibx' consistently when referring to Inbox refs '$inbox' is more human-readable, so that is for the more human-readable name in most cases. Making our variable naming more consistent should make the code easier-to-review and harder to screw up. --- lib/PublicInbox/AltId.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib/PublicInbox/AltId.pm') diff --git a/lib/PublicInbox/AltId.pm b/lib/PublicInbox/AltId.pm index 300bdc0b..c22b9598 100644 --- a/lib/PublicInbox/AltId.pm +++ b/lib/PublicInbox/AltId.pm @@ -18,7 +18,7 @@ use URI::Escape qw(uri_unescape); # The PREFIX will be a searchable boolean prefix in Xapian # Example: serial:gmane:file=/path/to/altmsgmap.sqlite3 sub new { - my ($class, $inbox, $spec, $writable) = @_; + my ($class, $ibx, $spec, $writable) = @_; my ($type, $prefix, $query) = split(/:/, $spec, 3); $type eq 'serial' or die "non-serial not supported, yet\n"; @@ -31,10 +31,10 @@ sub new { } split(/[&;]/, $query); my $f = $params{file} or die "file: required for $type spec $spec\n"; unless (index($f, '/') == 0) { - if (($inbox->{version} || 1) == 1) { - $f = "$inbox->{mainrepo}/public-inbox/$f"; + if (($ibx->{version} || 1) == 1) { + $f = "$ibx->{mainrepo}/public-inbox/$f"; } else { - $f = "$inbox->{mainrepo}/$f"; + $f = "$ibx->{mainrepo}/$f"; } } bless { -- cgit v1.2.3-24-ge0c7